The button to open the modal for the Modal display of the entity browser does not translate the value that is coming from the configuration.

CommentFileSizeAuthor
#6 3030765_6.patch639 bytesmpp
#4 3030765_4.patch665 bytesmpp
#2 3030765-2.patch591 bytesAshM

Comments

AshM created an issue. See original summary.

AshM’s picture

AshM commented
Status: Active » Needs review
StatusFileSize
new 3030765-2.patch591 bytes

This patch adds the call to the t method.

mpp’s picture

mpp commented
Status: Needs review » Needs work

The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there.

Read more at http://drupal.org/node/322732

You should probably translate that label using configuration translation.

mpp’s picture

mpp commented
Status: Needs work » Needs review
StatusFileSize
new 3030765_4.patch665 bytes

The label should be marked as translatable in the schema.

Status: Needs review » Needs work

The last submitted patch, 4: 3030765_4.patch, failed testing. View results

mpp’s picture

mpp commented
Status: Needs work » Needs review
StatusFileSize
new 3030765_6.patch639 bytes

Testing with a different type.

Status: Needs review » Needs work

The last submitted patch, 6: 3030765_6.patch, failed testing. View results

mpp’s picture

mpp commented
Status: Needs work » Needs review
mpp’s picture

mpp commented
Status: Needs review » Closed (duplicate)

Closing in favor of https://www.drupal.org/project/entity_browser/issues/2675390