Umami Copyright year in disclaimer block needs to be set to the current year at install time

This is a really interesting question - what does the Copyright on the bottom of the Umami demo mean?

The content of the Umami demo itself is not copyrighted, it's open source*. So presumably this is on the Umami demo just to demonstrate how you would implement such a block on your own website. Therefore I can't see any justification for using a range - we should just have the year of installation to stop this appearing progressively dated.

But given (*if) Umami content isn't actually copyrighted, is it misleading to have a copyright notice on it at all?

Also. specifically with regard to

Generate automatically through the theme (Then that field in the custom block won't be editable any more)

in the summary, if this is a suggestion to use a programmatic block, we should avoid that. The purpose of Umami is to demonstrate what you can do with Drupal without writing code as far as practical, excluding the theme layer.

* IANAL so feel free to correct me if this is wrong.

A Terms & Conditions page would need to be maintained and updated whenever licensing changes. I don't know how often this changes and whether that would cause the information to be outdated. Would it be better to link to the relevant information at an external source such as d.o. at about/licensing? Or a bit of information about the Umami project on a page with a link to the licensing information externally?

IANAL either so I don't know exactly what does and does not need to be stated, presumably it's just the same as loading up without the installation profile. But that legal message could be something friendly - an opportunity to encourage people to try the recipes, share the demo and learn about the licensing information if they wish.

Following a discussion on our weekly meeting, it has been decided that we create a patch that sets the copyright notice year to the current year, so we don't have to constantly update this year-on-year.

Any takers?

Oh I so wish I hadn't got sidetracked into reading about copyright this weekend ;-)

It seems the idea is to claim the copyright from the point at which it was first published, plus the latest date at which it was modified.

So, in the Drupal code example above, that should be All Drupal code is Copyright 2001 - 2019 by the original authors.

I suggest a slight alteration to the patch so far to reflect the first publication data of the demo?

@rachel_norfolk on the last weekly call it was decided that the intent of this block is to demonstrate a copyright notice you might implement on such a site, not claim copyright for Drupal or the Umami content.

https://docs.google.com/document/d/1ju4yXiONY-wvmLjLWqpcmxC5QAN5h_0iKeop...

So I don't think the change in #9 is what we want to do here. The intention is just to stop the demo now looking out of date, and to stop us having to manually update it every year.

I need to somehow find the time to catch up on those meetings - sorry!!

I think the answer here is that the out of date notice that this issue refers to is a separate issue with what notices should be in the footer. My suggestion would to be to review the patch in #8 as a solution for the original issue and then if there is the appetite to discuss further to open a related issue to determine what else should be there.

Confirming that patch #8 changes the date from 2018 to current year as intended.

Perfect, #8 works a charm; thanks a lot @shaal for working on this.

I tested that

1. The copyright date is the current year
2. The copyright date can be changed in the UI if editors wish

Alas, $copyright_message = '© ' . date("Y") . ' Terms & Conditions'; has whitespace at the end so would fail coding standards. Apart from that, this looks good.

Fixes #15 whitespace deleted at end of line.

@tonypaulbarker this is a great case for an interdiff, so that a reviewer can trivially check the whitespace is all that changed: https://www.drupal.org/documentation/git/interdiff

Thanks @Eli-T, how's this?

@tonypaulbarker looks awesome. Will RTBC as soon as the tests pass.

Tests passed. Marking as RTBC.

Adjusting credits.

Thanks, I agree this is a simple and good change.