The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.I first noticed and encountered this at #3028970-30: Audit all @todos. I was convinced I fixed it there, but apparently I did not. Even though on HEAD, it's D8.5+PHP5.5 that's failing, yet that's exactly what passed tests in #3028970-30! 🙅♂️
We first encountered this in #3001193: CommentTest::testPostIndividualDxWithoutCriticalBaseFields() fails on 8.7 since #2885809, which is where/why this began failing differently in Drupal 8.7 versus <8.7. On top of that, it's now behaving differently in PHP 5 vs PHP 7.
If only we'd fixed this in core years ago :(
Ah well, let's work around it yet more.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3029704-6.patch | 1.61 KB | wim leers |
| #2 | 3029704-2-whitespace_only_changes.patch | 650 bytes | wim leers |
Comments
Comment #2
wim leersFirst, let's observe it fail.
Comment #4
wim leersWTF, this time it passed, unlike https://www.drupal.org/pift-ci-job/1184958. Both are on
PHP 5.6 & MySQL 5.5, Drupal 8.5.x.Yet #3015325-23: [ignore] support issue for the core patch failed.
Comment #5
effulgentsia commentedOn https://www.drupal.org/node/2723491/qa, looks like it's the combination of jsonapi on Drupal 8.7 and PHP 5.5 that's failing.
Comment #6
wim leersYep, I had that figured out too. I had written what's below while you posted that :)
Aha, that's it. It only fails on 8.7 + PHP 5. I already knew about 5.5, but now 5.6 is also verified. Both fail when combined with Drupal 8.7. (Verified as of https://www.drupal.org/pift-ci-job/1187236.) I've been setting up my new machine in the past 48 hours, and it's nearly impossible to install PHP 5.5 on macOS Mojave. So I've been dependent on testbot to reach conclusions.
I then indeed was also able to reproduce it locally on 5.6. But only on Drupal 8.7. Not on 8.5. On 8.5, it passed.
Not surprising, because making PHP 5 + Drupal 8.5 work is exactly what #3028970-30: Audit all @todos tried to do! So fixing it on 8.5 broke it on 8.7.
All this started with #3001193: CommentTest::testPostIndividualDxWithoutCriticalBaseFields() fails on 8.7 since #2885809, which introduced a change for that test on Drupal 8.7, but failed to test both PHP 7 and 5. It worked on 7, but not on 5.
Still with me? Basically, Drupal core changed its behavior in 8.7. But the failure it's asserting is different on PHP 5 vs 7. So now we have lots of possible combinations. It's absurd.
This is what I manually tested:
Firing off ALL THE TESTS to verify.
Comment #7
wim leersHELL YES.
Just got back from a midnight run at -1°C to clear my head, this is all green! Looking forward to a good night’s rest, to then commit this in the morning and then forget about it forever!
Comment #9
wim leers💦🔥💦