Closed (fixed)
Project:
JSON:API
Version:
8.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Sep 2018 at 13:03 UTC
Updated:
12 Dec 2018 at 08:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
wim leersThis happens since #2975217: Update the default comment entity owner to the current user. That's commit
0b8908a1d2bdce266620443687ea6e5cfd2058a0. The commit before it passes tests.Comment #3
wim leersI think this difference can be explained by the fact that now the owner is no longer user zero, but the current user.
It'd be really great if this
Commententity weirdness that's documented in both\Drupal\Tests\jsonapi\Functional\CommentTest::testPostIndividualDxWithoutCriticalBaseFields()and\Drupal\Tests\comment\Functional\Rest\CommentResourceTestBase::testPostDxWithoutCriticalBaseFields()would get fixed… but other priorities, I know :(Comment #4
wim leers99.99% certain that #3 fails on 8.6 though. So we'll need to make that change conditionally.
Comment #6
wim leersIt'd also help if I rolled the patch correctly.
Comment #8
wim leersComment #9
wim leersD'oh, #2975217: Update the default comment entity owner to the current user just got reverted. Until that issue lands again, this issue is moot/postponed.
Comment #10
wim leerstestPostIndividualDxWithoutCriticalBaseFields()is failing again, not because #2975217: Update the default comment entity owner to the current user landed, but because its blocker #2885809: The 'entity_type' and 'field_name' base fields on Comment are required landed!Comment #11
wim leersRe-testing #8 against 8.6 and 8.7.
Comment #13
gabesulliceComment #15
gabesulliceD.o doesn't show it, but the last patch failed on 8.6: https://www.drupal.org/pift-ci-job/1132301
8.7 passed though, so.. progress!
Comment #16
gabesulliceThis should fix tests on 8.6.
Comment #18
gabesulliceBoth tests passed, I just introduced a CS violation 😭
Will commit if tests/sniffs pass on 8.6 and 8.7 since this is tests only and breaking HEAD.
Comment #20
gabesulliceComment #21
wim leers🍾