Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

Title: CommentTest::testPostIndividualDxWithoutCriticalBaseFields() fails on 8.7 » CommentTest::testPostIndividualDxWithoutCriticalBaseFields() fails on 8.7 since #2975217
Issue summary: View changes
Related issues: +#2975217: Update the default comment entity owner to the current user

This happens since #2975217: Update the default comment entity owner to the current user. That's commit 0b8908a1d2bdce266620443687ea6e5cfd2058a0. The commit before it passes tests.

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new3.38 KB

I think this difference can be explained by the fact that now the owner is no longer user zero, but the current user.

It'd be really great if this Comment entity weirdness that's documented in both \Drupal\Tests\jsonapi\Functional\CommentTest::testPostIndividualDxWithoutCriticalBaseFields() and \Drupal\Tests\comment\Functional\Rest\CommentResourceTestBase::testPostDxWithoutCriticalBaseFields() would get fixed… but other priorities, I know :(

wim leers’s picture

99.99% certain that #3 fails on 8.6 though. So we'll need to make that change conditionally.

Status: Needs review » Needs work

The last submitted patch, 3: 3001193-3.patch, failed testing. View results

wim leers’s picture

Status: Needs work » Needs review
StatusFileSize
new4.06 KB

It'd also help if I rolled the patch correctly.

Status: Needs review » Needs work

The last submitted patch, 6: 3001193-6.patch, failed testing. View results

wim leers’s picture

Status: Needs work » Needs review
StatusFileSize
new1.64 KB
new4.22 KB
wim leers’s picture

Priority: Critical » Major
Status: Needs review » Postponed

D'oh, #2975217: Update the default comment entity owner to the current user just got reverted. Until that issue lands again, this issue is moot/postponed.

wim leers’s picture

Title: CommentTest::testPostIndividualDxWithoutCriticalBaseFields() fails on 8.7 since #2975217 » CommentTest::testPostIndividualDxWithoutCriticalBaseFields() fails on 8.7 since #2885809
Status: Postponed » Needs review

testPostIndividualDxWithoutCriticalBaseFields() is failing again, not because #2975217: Update the default comment entity owner to the current user landed, but because its blocker #2885809: The 'entity_type' and 'field_name' base fields on Comment are required landed!

wim leers’s picture

Re-testing #8 against 8.6 and 8.7.

Status: Needs review » Needs work

The last submitted patch, 8: 3001193-8.patch, failed testing. View results

gabesullice’s picture

Assigned: wim leers » Unassigned
Status: Needs work » Needs review
StatusFileSize
new2.05 KB
new2.2 KB
new6.04 KB

Status: Needs review » Needs work

The last submitted patch, 13: 3001193-13.patch, failed testing. View results

gabesullice’s picture

D.o doesn't show it, but the last patch failed on 8.6: https://www.drupal.org/pift-ci-job/1132301

8.7 passed though, so.. progress!

gabesullice’s picture

Status: Needs work » Needs review
StatusFileSize
new1.22 KB
new5.96 KB

This should fix tests on 8.6.

Status: Needs review » Needs work

The last submitted patch, 16: 3001193-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

gabesullice’s picture

Status: Needs work » Needs review
StatusFileSize
new791 bytes
new5.93 KB

Both tests passed, I just introduced a CS violation 😭

Will commit if tests/sniffs pass on 8.6 and 8.7 since this is tests only and breaking HEAD.

  • gabesullice committed e22b0e7 on 8.x-2.x
    Issue #3001193 by gabesullice, Wim Leers: CommentTest::...
gabesullice’s picture

Status: Needs review » Fixed
wim leers’s picture

🍾

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.