Problem/Motivation

In #2920309: Add experimental module for Help Topics we tried to use final class to limit the API of the alpha experimental module. This was rejected by D8 release managers because @xjm noted

What we're saying is that right now, under current core policy, final should only be used for things that will never, ever be overridden, because that's what current core practice does. In general, I advise against tying this issue up in a policy discussion that hasn't been concluded (and is contentious).

https://www.drupal.org/project/drupal/issues/2920309?page=1 - comment #353

Proposed resolution

Allow experimental modules to use final as they see fit whilst in alpha and beta.

Remaining tasks

Further discussion.

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Note that I can not find any mention of final not being permitted or its valid as by core policy use-cases in https://www.drupal.org/docs/develop/standards/object-oriented-code or https://www.drupal.org/docs/develop/standards/coding-standards - but of course it's not easy to find things on d.o.

cilefen’s picture

cilefen commented

Have we mocked any final classes in phpunit? AFAIK it isn’t trivial. You can mock objects out of interfaces, so I guess that has not been an issue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Aside from mocking shortcomings, I am in favour of using final to enforce what is and isn't an extension point, along with private as well.

Language features will always be a stronger signal than documentation, convention and policies.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Title: Allow experimental modules to use final to limit public API during development phase » [Policy, no patch] Allow experimental modules to use final to limit public API during development phase
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@larowlan: you might want to state the same on #3019332: Use final to define classes that are NOT extension points.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.