Our site's server was recently upgraded to PHP 7.2.14. Drupal version: 7.63. Content Access version: 7.x-1.2-beta2

When modifying access permissions, receive this php warning:

Warning: count(): Parameter must be an array or an object that implements Countable in content_access_page() (line 55 of /[docroot]/sites/all/modules/content_access/content_access.admin.inc).

CommentFileSizeAuthor
#7 php72-countable-3026681-7.patch741 bytescafuego
#5 count_php_7_2-3026681-5.patch754 bytesamsteri
#4 local_history.patch1015 bytestarik.cipix

Comments

memcinto created an issue. See original summary.

memcinto’s picture

memcinto commented

Maybe a patch something like this? (Starting at around line 50 of content_access.admin.inc)

  $my_custom_access_grants = content_access_get_per_node_settings($node);
  
  if ($my_custom_access_grants > 0) {
  	$my_custom_access_grants_boolean = TRUE;
  } else {
  	$my_custom_access_grants_boolean = FALSE;
  }

  $form['reset'] = array(
    '#type' => 'submit',
    '#value' => t('Reset to defaults'),
    '#weight' => 10,
    '#submit' => array('content_access_page_reset'),
    // '#access' => count(content_access_get_per_node_settings($node)) > 0,
    '#access' => $my_custom_access_grants_boolean,
  );
salvis’s picture

salvis
he/his
commented

Please check the -dev version first and provide a patch against that if needed.

tarik.cipix’s picture

tarik.cipix commented
Version: 7.x-1.2-beta2 » 7.x-1.x-dev
StatusFileSize
new local_history.patch1015 bytes

Here is a patch

amsteri’s picture

amsteri commented
StatusFileSize
new count_php_7_2-3026681-5.patch754 bytes
tarik.cipix’s picture

tarik.cipix commented

Amsteri,

You're calling the function twice, I fixed it below, also added a question. Not sure about the else contents.

  $res = content_access_get_per_node_settings($node);

  if (is_array($res)) {
    $form['reset']['#access'] = count($res) > 0;
  }
  else {
    // @todo: can we really compare this value with an int?
    $form['reset']['#access'] = $res > 0;
  }
cafuego’s picture

cafuego commented
StatusFileSize
new php72-countable-3026681-7.patch741 bytes

Rather than try to shoe-horn the return value to be countable and then produce a boolean for the #access value, you can check if the returned settings array is empty or not and everything should work as intended without code warnings.

Array empty => #access FALSE => reset button disabled.

salvis’s picture

salvis
he/his
commented
Status: Active » Needs review

Yes, empty() covers all relevant cases.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

That looks like the correct solution for this!

Anonymous’s picture

Anonymous (not verified) commented

patch #7 worked for me in php 7.3

  • cafuego authored e3d314e on 7.x-1.x 
    Issue #3026681 by tarik.cipix, cafuego, Amsteri, memcinto, salvis,...
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Reviewed & tested by the community » Fixed

Fixed in 7.1-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.