Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
16 Jan 2019 at 11:29 UTC
Updated:
28 Mar 2019 at 16:04 UTC
Jump to comment: Most recent
Comments
Comment #2
adigunsherif commentedComment #3
avpadernoThank you for your contribution!
Remember to change status, when the project is ready to be reviewed. The actual status is not telling users to review it.
Comment #4
adigunsherif commentedComment #5
avpadernoThe @file directive is not used in the doc block for a function. The empty line between the doc block and the function needs to be removed.
The code formatting needs to adhere to the Drupal coding standards.
The code committed in Drupal.org repositories need to be licensed under the GPLv2+ license, as the Drupal Git Contributor Agreement & Repository Usage Policy. The code inside the bootstrap directory is licensed under the MIT license.
Comment #6
avpadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.
Comment #7
adigunsherif commentedThank you. Now, i've updated the dev version. Once this review is complete, I'll release a new tag
Comment #8
avpadernoComment #9
klausiIt is hard to review this theme, can you fix all the coding standard issues reported at https://pareview.sh/pareview/https-git.drupal.org-project-adminlte_theme... ?
Font awesome is included in the repository, I think this is GPL compatible according to https://fontawesome.com/license/free . It is still recommended to not have 3rd party libraries in git, see https://www.drupal.org/node/422996 . Same for all the other libraries that you include.
page--user--login.tpl.php: all user facing text must run thorugh t() for translation.
The coding standards and the third party libraries are not application blockers, otherwise I could not see any security issue.
Comment #10
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.