Admin LTE was originally developed by https://adminlte.io/ and Drupalized by Adigun Sherif for Drupal site builders.

Project Page

https://www.drupal.org/project/adminlte_theme

Git instructions

git clone --branch 7.x-2.x https://git.drupal.org/project/adminlte_theme.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-adminlte_theme...

Comments

adigunsherif created an issue. See original summary.

adigunsherif’s picture

Issue summary: View changes
avpaderno’s picture

Thank you for your contribution!
Remember to change status, when the project is ready to be reviewed. The actual status is not telling users to review it.

adigunsherif’s picture

Status: Active » Needs review
avpaderno’s picture

Status: Needs review » Needs work
/**
 * @file
 * Stub file for adminlte_theme_menu_tree() and suggestion(s).
 */

function adminlte_theme_menu_tree(array &$variables) {
  return '<ul class="sidebar-menu" data-widget="tree">' . $variables['tree'] . '</ul>';
}

The @file directive is not used in the doc block for a function. The empty line between the doc block and the function needs to be removed.

function adminlte_theme_menu_link(array $variables) {
	$output = '';
	$element = $variables['element'];
	$sub_menu = '';
	if (in_array('expanded', _bootstrap_get_classes($element))){
		$element['#attributes']['class'][] = "treeview";
	}
	
	$options = !empty($element['#localized_options']) ? $element['#localized_options'] : array();

	// Check plain title if "html" is not set, otherwise, filter for XSS attacks.
    $title = empty($options['html']) ? check_plain($element['#title']) : filter_xss_admin($element['#title']);
	
	$options['html'] = TRUE;
	$href = $element['#href'];
  $attributes = !empty($element['#attributes']) ? $element['#attributes'] : array();
	// if link class is active, make li class as active too
	if(strpos($output,"active")>0){
	  $element['#attributes']['class'][] = "menu-open";
	}	
	
	if ((!empty($element['#original_link']['depth'])) && ($element['#original_link']['depth'] == 1)) {
      // Add our own wrapper.
      unset($element['#below']['#theme_wrappers']);
      $sub_menu = '<ul class="treeview-menu">' . drupal_render($element['#below']) . '</ul>';

      // Generate as standard dropdown.
      if (in_array('treeview', _bootstrap_get_classes($element))){
		  $title .= ' <span class="pull-right-container"><i class="fa fa-angle-left pull-right"></i></span>';
	  }
    }
	
	return '<li' . drupal_attributes($element['#attributes']) . '>' .  l($title, $href, $options) . $sub_menu . "</li>\n";
  
}

The code formatting needs to adhere to the Drupal coding standards.

The code committed in Drupal.org repositories need to be licensed under the GPLv2+ license, as the Drupal Git Contributor Agreement & Repository Usage Policy. The code inside the bootstrap directory is licensed under the MIT license.

avpaderno’s picture

Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.

adigunsherif’s picture

Status: Closed (won't fix) » Needs review

Thank you. Now, i've updated the dev version. Once this review is complete, I'll release a new tag

avpaderno’s picture

Issue summary: View changes
klausi’s picture

Component: module » theme
Status: Needs review » Reviewed & tested by the community

It is hard to review this theme, can you fix all the coding standard issues reported at https://pareview.sh/pareview/https-git.drupal.org-project-adminlte_theme... ?

Font awesome is included in the repository, I think this is GPL compatible according to https://fontawesome.com/license/free . It is still recommended to not have 3rd party libraries in git, see https://www.drupal.org/node/422996 . Same for all the other libraries that you include.

page--user--login.tpl.php: all user facing text must run thorugh t() for translation.

The coding standards and the third party libraries are not application blockers, otherwise I could not see any security issue.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.