This module is a Domain Access submodule that makes long, unwieldy check boxes (Domain Access and Domain Admin fields) much more user-friendly, using Chosen jQuery plugin.

Project link

https://www.drupal.org/project/domain_chosen_select

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/domain_chosen_select.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-domain_chosen_...

CommentFileSizeAuthor
#14 20190123-185834.png22.76 KBavpaderno
#12 Screenshot 2019-01-23 at 17.55.58.png213.64 KBkwadz

Comments

Kwadz created an issue. See original summary.

saesa’s picture

saesa commented
Issue summary: View changes
Status: Needs review » Needs work

I think that for the module to be revised it has to be a project not a sandbox. You should create the 8.x-1.x branch and delete the master branch.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

We also review sandbox projects.
In fact, the original purpose of these applications was giving users the permission to create full projects. The purpose has been then changed, but we still review sandbox projects.

kwadz’s picture

kwadz commented

I have created the 8.x-1.x branch and have delete the master branch.

I'd like to promote my sandbox project to a full project, according to these instructions.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@Kwadz You can either do it before this application is approved, or when it is approved. Whenever you are fine with doing it, we are fine too. We don't force users to promote their projects before applying.

kwadz’s picture

kwadz commented

Thank you @kiamlaluno for this clarification. I have just promoted the sandbox project to a full project.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
kwadz’s picture

kwadz commented
Issue summary: View changes
kwadz’s picture

kwadz commented

To follow the rule "All functions should be prefixed with your module/theme name (domain_chosen_select) to avoid name clashes", I wanted to rename the project domain_chosen_select instead of domain_chosen_select_boxes.

So, I created a new project (since we can't rename directly). That said, the new git repository displays a link to the old one. I have committed and pushed to make sure it's not a cache issue but it's the same.

How can I remove this link and make the new repo display itself?

kwadz’s picture

kwadz commented

Would anyone be able to fix the Git repo issue? And even delete the previous project

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Parent issue: #3002849: Improving the way how the domains are selected »

Clicking on the Browser code repository link given on https://www.drupal.org/project/domain_chosen_select, I am taken to https://cgit.drupalcode.org/domain_chosen_select, which seems an empty repository.
If you have troubles committing code in that repository, the Drupal.org Infrastructure Team could provide help.

kwadz’s picture

kwadz commented
StatusFileSize
new Screenshot 2019-01-23 at 17.55.58.png213.64 KB

OK, thank you @kiamlaluno. On my side I get the following:

Screenshot

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

With the access level I have, I cannot find out what is happening, and why. The Infrastructure Team has the tools and the expertise to understand what is the issue and fix it.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
StatusFileSize
new 20190123-185834.png22.76 KB

Actually, the link given in https://www.drupal.org/project/domain_chosen_select is not the repository link, but a link to a search page.

screenshot

The true link is https://cgit.drupalcode.org/domain_chosen_select/ with a slash at the end.

kwadz’s picture

kwadz commented

Good catch @kiamlaluno! I opened an issue to the Infrastructure Team.

kwadz’s picture

kwadz commented

The domain_chosen_select repo is now working as expected. However when I want to submit the clone address to PAReview something is loading and then nothing happens.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

PAReview has not done any review since January 21, 2019. That is an issue from their side.

If you need to check your code, you may install Coder on your computer. That is the tool used from PAReview too.

kwadz’s picture

kwadz commented

Thanks, I pushed a commit to fix coding style according to Coder results.

kwadz’s picture

kwadz commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kwadz’s picture

kwadz commented

There is still the statement "This project is not covered by Drupal’s security advisory policy." in the project page. Is it normal?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@Kwadz You need to edit the project. We just give the permission to do that. See the Security advisory coverage field on https://www.drupal.org/node/3026538/edit.