Hi there,

I am trying to use the feature to Add Settings handler.

After hitting Save, the Add Settings handler form is still open, it doesn't save it.

I tried installing the dev version, but still can't save the Add Settings handler.

Help please!

CommentFileSizeAuthor
#5 3024048-5.patch795 bytesjrockowitz

Comments

yalegria created an issue. See original summary.

yaach’s picture

yaach commented

This is why I got on my logs after hitting the save button:

Unsupported operand types in /opt/drupal/modules/contrib/webform/src/Plugin/WebformHandler/SettingsWebformHandler.php on line 267

Hope that helps.

jrockowitz’s picture

jrockowitz commented

There is most likely an error being logged in the browser's JS console and Drupal's Recent log messages (/admin/reports/dblog).

Please provide the error message and the steps required to reproduce this issue.

jrockowitz’s picture

jrockowitz commented

I was able to replicate this issue by adding a new settings handler and making no changes.

The error message is…

The website encountered an unexpected error. Please try again later.
Error: Unsupported operand types in Drupal\webform\Plugin\WebformHandler\SettingsWebformHandler->submitConfigurationForm() (line 267 of modules/sandbox/webform/src/Plugin/WebformHandler/SettingsWebformHandler.php).

jrockowitz’s picture

jrockowitz commented
Priority: Normal » Critical
StatusFileSize
new 3024048-5.patch795 bytes
jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
Related issues: +#3018611: Use WebformHandlerBase::setSettingsParentsRecursively to simplify handler configuration forms

This regression was caused by #3018611: Use WebformHandlerBase::setSettingsParentsRecursively to simplify handler configuration forms and does result in site builders losing their custom settings.

  • jrockowitz committed 02ae4f8 on 8.x-5.x 
    Issue #3024048 by jrockowitz: Can't save a new Settings Handler
jrockowitz’s picture

jrockowitz commented
Priority: Critical » Major

I committed the patch. Please download the latest dev release to review.

This is not as critical as I originally thought because the fatal error prevents any data loss.

I will tag a new release later this week.

yaach’s picture

yaach commented
Priority: Major » Normal
Status: Needs review » Active

Hey jrockwitz, you are the man!

it is working now after pulling dev.

Thanks.

jrockowitz’s picture

jrockowitz commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.