[2.0.x] Remove jQuery dependency

@arthur_lorenz, Here's the patch as per the requested changes mentioned above, I removed the jquery dependency from libraries.yml

No, we definitely can't use that patch :)
It's a monumental task though, to remove reliance of jquery, and it would have to be done for both d7 and d8.

We need a patch for Drupal 7 before we can add this to the dev branch.

Why is that? Because of feature equality?

Yes. It will be really hard to maintain a stable module and offer equal support to 7 and 8 if the scripts are vastly different.

I'm going to change my mind on that, and start adding features to 8.x without requiring a backport to 7.x.

Luckily the patch still applies, I'll do some testing and try to commit this later.

I gave the code a go, and it fails with the cookie categories feature. There's an error thrown when the module tries to read the json saved in the [cookie-name]-categories cookie.

I didn't test it further. If you could look into that it would be great. I will return to this, but there's a lot of open issues at the moment.

Thanks. I'll have a look later.

Whatever we'll do here, this is definitely a candidate for a separate branch! The patch is quite large and will require very many rerolls over time, whenever other issues are fixed.
That costs a lot of volunteers time nobody here likes to invest, I guess.

So if this is an option, it should become a separate 2.x branch which then requires all other issues to be also fixed there, but keep things separate and clean.

I'd suggest to first have a sprint in 8.x-1.x to create a new stable release with all important RTBC'd patches, wait for some weeks for regression issues and then create a separate branch and proceed there as quickly as possible to prevent duplicate issues.

BTW I don't think it will make sense to backport that to D7 because of EOL!

+1 for that ==> #3130662: Roadmap to 2.0.x release

The setCookie did not set the options to the cookie. I fixed that and rerol it for the latest dev.

Patch #25 does not work for me, probably because I'm using 8.x-1.9

But apart from that, patch 25 does not cover all the changes of #19, check line 314 of the patch. Probably it was missed. PAtch 25 does good job of adding cookie options properly.

I also noticed some important bugs of Patch 19, which creates functional problems, specially the cookie removal process.
Adding interdiff wrt Patch 19 as well, for better visibility.

@purushotam.rai – So is your patch now against latest dev or against 1.9?

It's 1.9 as of now.

Thank you for clarification. Do you see any chance to create the patch from the latest dev to let the tests run and let others review it properly and enable the maintainers to apply and push it?

Thanks all for the monumental work being done in this issue.

Just heads up - we have a lot of patches going into -dev these days, so you may need to do multiple re-rolls to catch up.

I see a lot of setting the status to "Needs review", though it would be useful if somebody has time to test all features (or even better, start writing tests) with this patch applied so that we know we're not breaking any part of the module when we remove jQuery.

The patch needs a re-roll (though it's probably a good idea to hold off for now).

I'd like to ask a question about the Javascript in this module, as I see there keeps being some movement in this issue.

If you had the choice, would you rather help restructure the javascript so that it's more object oriented and easier to maintain in the long run, or do you prefer to move the script from #27 to 2.0.x and then maybe stripping away some of the functionality that we don't want to bring forward to 2.0.x?

Hi svenryen,

from my perspective 2.x should definitely be a complete rewrite and we should not copy any code, just learn from 1.x what worked well and what didn't. For the JS part that means for me, that we should focus on API thinking and split into general logic (API / model) which could even be controlled from outside, for example by third party modules (a concrete example would be to have a module adding a layer to (de)select categories or add options to the privacy policy to opt in / out, etc.).

In the eu_cookie_compliance logic these general functionalities are also simply called ("business logic"). There are several cases in the issue que where the problem was, that the current code was too complex and had side-effects to allow calls from extending modules.

This would help a lot to improve the readability & testability of the code and allow easier integration and modification.

My two cent ;)

I'd be happy to help test this and get this much needed feature into 2.x. But unfortunately the current patch does not apply to 1.14 or dev. Any chance this patch could be updated so we could review it.

Thanks.

I think it's fair to say we will need to rewrite the javascript in version 2 (mainly because it's grown out of hand with all the patches we've accumulated over nearly a decade), so making this patch apply to 1.x may not be the best way to allocate resources (although you're welcome to spend time on that if you wish as it could be a valuable patch for those on 1.x that would like to remove jquery).

I'm closing this issue as the script will be rewritten in 2.x and we won't need this patch.

Though thanks a lot for the effort that went into this issue.

for anyone who might need it, here's a patch for 1.9

Hi All,
going to close this as i've done a pile of work in https://www.drupal.org/project/eu_cookie_compliance/issues/3552718 to remove the current jquery.

it's still in beta testing, but i think it covers most aspect of what the module needs to do.