Error: Call to undefined function _backup_migrate_temp_files_delete()

Do you have any modules installed which add more destinations or sources?

Does this help?

Ok excellent.

Need to add some test coverage to make sure it works as intended.

I got the same error after updating a basic backup_migrate to 3.6. The patch in #4 fixed it

Patch #4 appears to work and can't find adverse effects

#4 works for me

#4 works for me, too

Any suggestion as to what this test coverage would look like?

patch #4 Work for me.

Patch #4 worked for me too. Thanks!

Works fine.

Works for me.

Works for me.

Does anybody know how to add tests for something like this? I have no experience with creating unit tests. Personally, I'd just commit the fix.

If someone could identify the steps to reproduce the problem I'm happy to write the tests for it, I just haven't managed to trigger the problem yet.

Well, I know it happens specifically after updating from the 2.x branch to the 3.x branch, so I don't think it's related solely to this branch's code.

I didn't update the module, originally I worked with the most recent stable version 7.x-3.6, when I opened the "Restore" menu item, I bumped straight into this message. Then I drush dl backup_migrate-7.x-3.x-dev and the error still persisted.

I can confirm a patch from #4 above fixes this issue and it may be reviewed/ported to dev.

Note that for an upgrade test you would need to reproduce the database state from before and after the update. I know how this is done for core, but have no proper ideas on how to do this for contrib modules.

Simpler would be to just test the target state, i.e. do the pages admin/config/system/backup_migrate/restore and admin/config/system/backup_migrate/backups load properly?

Hm. In the meantime I updated Drupal core to v7.67 and all the modules, tested it again without patch from #4 above and now I could open all the menu items from this module with no error messages.

Once the temp files have been deleted, removing the patch won't do anything to break it again.

I'm going to forego the need for tests and just commit this, I don't believe there's any likelihood of a regression so it should be a-ok.

Thanks everyone.

Looks like this is still waiting to be committed?

Committed.