Blocks derived from facet_block are mising config schema so I'm attaching a patch including it

CommentFileSizeAuthor
#8 interdiff-3023187-4-8.txt355 byteschr.fritsch
#8 3023187-8.patch375 byteschr.fritsch
#4 interdiff-1-4.txt547 bytespiggito
#4 missing_schema_facet_blocks-3023187-4.patch374 bytespiggito
#2 missing_schema_facet_blocks.patch519 bytespiggito
block_config_schema.patch1.69 KBpiggito

Comments

piggito created an issue. See original summary.

piggito’s picture

piggito commented
StatusFileSize
new missing_schema_facet_blocks.patch519 bytes

Attaching correct file, previous one was wrong.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented 
+++ b/config/schema/facets.blocks.schema.yml
@@ -0,0 +1,7 @@
+  label: 'Language DropDown Switcher'

This label doesn't seem right :)

piggito’s picture

piggito commented
StatusFileSize
new missing_schema_facet_blocks-3023187-4.patch374 bytes
new interdiff-1-4.txt547 bytes

Sorry my bad. Attaching patch with new label.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

alexandersluiter’s picture

alexandersluiter commented

Typo? Last line says "labe: 'Block ID'"...should read "label...", correct?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Needs work

Needs work based on #6.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 3023187-8.patch375 bytes
new interdiff-3023187-4-8.txt355 bytes

Here is a new patch with the key name fix.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Awesome, thanks!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.