removing functions in Drupal\KernelTests\AssertLegacyTrait

CommentFileSizeAuthor
#2 entity-embed-3023051-2.patch8.49 KBoknate

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-embed-3023051-2.patch8.49 KB

- updating assertIdentical to assertSame (order of expected and actual reverses).
- Changing AssertEqual to AssertEquals (order of expected and actual reverses, but it looks like right now, the order was incorrect, so just renaming the function should be enough).

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Coding standards, +Drupal 9

Retesting, but looks good to me! :) Once it comes back green, I'll commit this.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2974668: Convert module to use short array syntax (new coding standard)
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: update deprecated functions in tests » Stop using deprecated assertIdentical() and assertEqual() functions in tests

  • Wim Leers committed e6c88a4 on 8.x-1.x authored by oknate 
    Issue #3023051 by oknate, Wim Leers: Stop using deprecated...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Drupal 9 +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.