We have to convert the module to short array syntax as per new coding standards.

CommentFileSizeAuthor
#6 entity-embed-short-array-syntax-2974668-6.patch55.29 KBoknate
#2 2974668-2.patch55.32 KBdeepakkumar14
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

deepakkumar14 created an issue. See original summary.

deepakkumar14’s picture

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
FileSize
2974668-2.patch55.32 KB

Submit patch for this.

Status: Needs review » Needs work

The last submitted patch, 2: 2974668-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +phpcs

Still applies cleanly!

The same test failures are happening to entity_embed HEAD. This is ready.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Nice work, but needs a reroll. :(

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
FileSize
entity-embed-short-array-syntax-2974668-6.patch55.29 KB

reroll

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll

Green!

  • Wim Leers committed baceb17 on 8.x-1.x authored by oknate 
    Issue #2974668 by deepakkumar14, oknate: Convert module to use short...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.