CommentFileSizeAuthor
#16 interdiff_15_16.txt7.98 KBnixou
#16 3022651-16.patch6.41 KBnixou
#16 3022651-16-test-only.patch1.8 KBnixou
#15 3022651-15.patch7.22 KBnixou
#14 r4032login-redirect_ignore_destination_parameter-3022651-14.patch7.13 KBsachint1996
#13 r4032login-redirect_ignore_destination_parameter-3022651-10.patch7.13 KBsachint1996
#11 r4032login-redirect_ignore_destination_parameter-3022651-9.patch6.42 KBsachint1996
#8 r4032login-redirect_ignore_destination_parameter-3022651-8.patch5.53 KBsachint1996
#5 r4032login_redirect_ignore_destination_parameter_3022651_5_D8.patch6.27 KBabhaysaraf
#4 r4032login_redirect_negate_strictly_3022651_3_D8.patch4.07 KBabhaysaraf
#2 r4032login_redirect_negate_3022651.patch3.29 KBrutel95

Comments

ruslan_03492 created an issue. See original summary.

rutel95’s picture

rutel95
Primary language Russian
Location Wroclaw
commented
StatusFileSize
new r4032login_redirect_negate_3022651.patch3.29 KB

Status: Needs review » Needs work

The last submitted patch, 2: r4032login_redirect_negate_3022651.patch, failed testing. View results

abhaysaraf’s picture

abhaysaraf commented
StatusFileSize
new r4032login_redirect_negate_strictly_3022651_3_D8.patch4.07 KB

Resolving strictly redirections for non-negated matching pages.

abhaysaraf’s picture

abhaysaraf commented
StatusFileSize
new r4032login_redirect_ignore_destination_parameter_3022651_5_D8.patch6.27 KB

Available with below checkbox option at- admin/config/system/site-information:

[x] Ignore Destination query parameter from request.
If 403 occur for request mypage1?destination=mypage2, then enabling this will target mypage1 instead of mypage2.

Important: This patch also cover patch#4.

nixou’s picture

nixou commented
Version: 8.x-1.x-dev » 2.x-dev
sachint1996’s picture

sachint1996 commented
Assigned: Unassigned » sachint1996
sachint1996’s picture

sachint1996 commented
Status: Needs work » Needs review
StatusFileSize
new r4032login-redirect_ignore_destination_parameter-3022651-8.patch5.53 KB

Patch created for 2.x branch

sachint1996’s picture

sachint1996 commented
Assigned: sachint1996 » Unassigned

Status: Needs review » Needs work

The last submitted patch, 8: r4032login-redirect_ignore_destination_parameter-3022651-8.patch, failed testing. View results

sachint1996’s picture

sachint1996 commented
Status: Needs work » Needs review
StatusFileSize
new r4032login-redirect_ignore_destination_parameter-3022651-9.patch6.42 KB

The previous patch was incomplete. This one adds the 'negate' parameter in the test file.

Status: Needs review » Needs work

The last submitted patch, 11: r4032login-redirect_ignore_destination_parameter-3022651-9.patch, failed testing. View results

sachint1996’s picture

sachint1996 commented
Status: Needs work » Needs review
StatusFileSize
new r4032login-redirect_ignore_destination_parameter-3022651-10.patch7.13 KB

Rerolled the patch with test file updated.

sachint1996’s picture

sachint1996 commented
StatusFileSize
new r4032login-redirect_ignore_destination_parameter-3022651-14.patch7.13 KB

Uploaded the same patch with correct comment ID as per the norms.

nixou’s picture

nixou commented
StatusFileSize
new 3022651-15.patch7.22 KB

Reroll against latest dev

nixou’s picture

nixou commented
StatusFileSize
new 3022651-16-test-only.patch1.8 KB
new 3022651-16.patch6.41 KB
new interdiff_15_16.txt7.98 KB

I could not understand what was the purpose of ignore_destination_parameter as we already have an option to enable or disable the destination parameter.

I also tried the option while skipping or allowing redirection for some urls but it seems not to make any difference so I removed it.

I reorganized the code and added tests to cover the negate part of the condition.

Let's see if tests are ok.

The last submitted patch, 16: 3022651-16-test-only.patch, failed testing. View results

  • Nixou committed 068af6a on 2.x 
    Issue #3022651 by SachinT1996, Nixou, abhaysaraf, rutel95: Support...
nixou’s picture

nixou commented
Status: Needs review » Fixed

Thank you very much.

Committed to 2.x-dev, will be released in 2.1.1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.