From #2843147-97: Add JSON:API to core as a stable module, where we're moving JSON:API into core:
+ * specification. By its own definition, the JSON:API specification is "is adouble "is". ;)
+ * a later specification. Remember that he specification stipulates that futures/he/the/
Otherwise, I love the jasonapi.api.php file and what it represents. ;) No more time today for further reviews, but this is clearly very close to RTBC.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3021873-8.patch | 1.2 KB | dww |
| #5 | 3021873-5.patch | 1.2 KB | govind.maloo |
| #3 | 3021873-3.patch | 678 bytes | govind.maloo |
Comments
Comment #2
dwwThanks for moving this upstream.
They're just bugs in PHPDoc comments, not any code.
Cheers,
-Derek
Comment #3
govind.maloo commentedComment #4
wim leers#2: hah, thanks :)
#3: @govind.maloo Thanks for fixing the first! Could you also fix the second nit? :)
Comment #5
govind.maloo commentedComment #6
govind.maloo commentedComment #7
wim leersPerfect, thanks! 👍
Comment #8
dwwExcept we lost the opening " mark while fixing nit 1.
Use this instead. ;)
Cheers,
-Derek
Comment #10
gabesulliceThanks @govind.maloo & @dww!
Comment #12
gabesulliceSorry @govind.maloo, I should have set you as the author of the first commit.
Comment #13
wim leers@dww: damn, you see all the nits. Thank you so much! :D