Hi

When I unisntalling the module, I got the error message to stop me finish.

Error: Call to undefined function xmlsitemap_clear_directory() in xmlsitemap_uninstall() (line 372 of /home/abccom/public_html/sites/all/modules/xmlsitemap/xmlsitemap.install).

CommentFileSizeAuthor
#9 xmlsitemap-improve-uninstall.patch675 bytesjacob.embree
#3 After patch.png38.4 KBriddhi.addweb
#3 Before patch.png63.89 KBriddhi.addweb
#2 xmlsitemap-3020270-2.patch477 bytesjigish.addweb

Comments

freelylw created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
StatusFileSize
new xmlsitemap-3020270-2.patch477 bytes

@freelylw, Here's the patch to resolve the error that occurs on module uninstall. Hope this helps you!. Thanks

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before patch.png63.89 KB
new After patch.png38.4 KB

@jigish.addweb, Thanks for providing a patch, I checked it using simplytest.me & got the same error without a patch, using your patch I found that issue is resolved. PFA

Thanks for all your work!...

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Looks good! Thanks

alex_optim’s picture

alex_optim
Location Tallinn
commented

+1

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

  • pifagor committed b60d230 on 7.x-2.x authored by jigish.addweb 
    Issue #3020270 by jigish.addweb, riddhi.addweb, freelylw, alex_optim,...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed
jacob.embree’s picture

jacob.embree commented
StatusFileSize
new xmlsitemap-improve-uninstall.patch675 bytes

The only reason xmlsitemap_clear_directory() might not exist is if xmlsitemap.module hasn't been loaded. The very next line loads xmlsitemap.module, so why not load xmlsitemap.module first, then run xmlsitemap_clear_directory(), then remove variables?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ciss’s picture

ciss commented

I have to agree with @jacob.embree, the committed changes only patch the symptoms, not the cause. The patch in #9 would be in line with the original intent.

@jacob.embree If this issue doesn't get reopened, do you feel like creating a follow-up?

jacob.embree’s picture

jacob.embree commented

Sure, ciss. Here it is: #3086542: Clean up uninstall routine.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Closed (fixed) » Needs work
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs work » Fixed

This will close another task - https://www.drupal.org/project/xmlsitemap/issues/3086542

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.