Closed (fixed)
Project:
Facets
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Dec 2018 at 10:15 UTC
Updated:
26 Feb 2019 at 19:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mfernea commentedComment #3
mfernea commentedHere is the patch.
Comment #4
gngn commentedThere is a similiar problem with core 8.5:
Using drupal core 8.5 I cannot execute the facets_update_8006().
drush updatedbshows the update info "Update facet blocks configuration with a block id used for AJAX support" (taken from the description of facets_update_8006) but the function is never called.I digged a little deeper and found:
facets_update_dependencies())(update number 8600 -> core 8.6)
facets_update_dependencies()blocks the execution offacets_update_8006()until block_content update 8600 is performed - which is never!facets_update_8006()is never executed!drush updatedbwill show facets_update_8006 again and again!See hook_update_N() and hook_update_dependencies().
I think we need to check drupal version too.
Patch attached.
P.S. I did not find this issue at first, so I created a new one (#3027801). Closing that one now.
Comment #5
gngn commentedPatch #4 without file mode change.
Also updated description.
Comment #6
borisson_Looks good, maybe we should introduce a dependency on core 8.6 in the same patch as well?
Comment #7
gngn commented@borisson_ : the module is running with 8.5 so I do not think we should add an 8.6 dependency.
It's just if you have 8.6 (and block_content is enabled), than you need to execute update block_content 8600 before update facets_update_8006.
Comment #8
borisson_Committed and pushed.