Since updating to 8.x-3.1, I'm unable to run drush because it's looking for the salesforce_mapping entity, which is not present on my system. Context: the project I'm working on doesn't have the salesforce_mapping installed, which I presume is what causing the error.

I'll try to work on a patch next week, possibly, but in the meantime the possible solutions I have in mind are:

  1. Checking that salesforce_mapping is installed before calling $etm->getStorage('salesforce_mapping') (SalesforceCommandsBase.php:38)
  2. Moving any mapping-specific drush code to salesforce_mapping (I think this would be much better).
CommentFileSizeAuthor
#6 salesforce-drush-3018851-6-D8.patch16.57 KBcwcorrigan
#5 salesforce-drush-3018851-5-D8.patch15.82 KBcwcorrigan
#4 salesforce-drush-3018851-4-D8.patch15.87 KBcwcorrigan

Comments

antiorario created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Title: Error running drush: The "salesforce_mapping" entity type does not exist » Move mapping-related methods out of salesforce core module, and into salesforce_mapping module
Category: Bug report » Task

Let's go with option #2

Moving any mapping-specific drush code to salesforce_mapping (I think this would be much better).

I think this will leave us with 1 method in SalesforceCommandsBase. The rest can go into SalesforceMappingCommandsBase or a SalesforceMappingCommandsTrait, as needed, and Push and Pull commands can be updated to reference the new classes.

Make sense?

antiorario’s picture

antiorario commented

Makes total sense!

cwcorrigan’s picture

cwcorrigan commented
StatusFileSize
new salesforce-drush-3018851-4-D8.patch15.87 KB

Quick pass at moving them.

cwcorrigan’s picture

cwcorrigan commented
StatusFileSize
new salesforce-drush-3018851-5-D8.patch15.82 KB

Re-roll off the d.o repo

cwcorrigan’s picture

cwcorrigan commented
StatusFileSize
new salesforce-drush-3018851-6-D8.patch16.57 KB
  1. Cleaned up a warning that was popping up due to previous patch
  2. Corrected typo in command for salesforce:query-object (was salesforcef:query-object)
cwcorrigan’s picture

cwcorrigan commented
Status: Active » Needs review

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Fixed

Looks good - thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.