Problem/Motivation

While theeming the throbber I wondered, why the webform's throbber on a form w/o ajax was not in my custom design.
I follow the approach to add dependencies to libraries via hook_library_info_alter(), and use drupal.progress for this particular case.

Proposed resolution

As webform.form.submit_once.js adds drupal's progress indicator, it's library should also depend on drupal.progress!

CommentFileSizeAuthor
#2 3017594-2_submit-once-progress-dependency.patch342 bytesytsurk

Comments

ytsurk created an issue. See original summary.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes
StatusFileSize
new 3017594-2_submit-once-progress-dependency.patch342 bytes

Here's the patch

ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes
Status: Active » Needs review

  • jrockowitz committed da03faf on 8.x-5.x authored by ytsurk 
    Issue #3017594 by ytsurk: submit_once library should depend on drupal....
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Thanks for the patch.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes

woaw - this was pretty quick ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.