I'm using Drupal 8.6.3 and PHP 7.1.22. I installed trailing_slash using composer but I can't enable it because of PHP version incompatibility:

$ drush en trailing_slash
trailing_slash is incompatible with the PHP version.
CommentFileSizeAuthor
#6 php-incompatibility-3016988-6.patch1.46 KBdan612
#3 3016988-1_php-incompatibility.patch239 bytesrobertoperuzzo

Issue fork trailing_slash-3016988

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

robertoperuzzo created an issue. See original summary.

robertoperuzzo’s picture

robertoperuzzo
Primary language Italian
Location 🇮🇹 Tezze sul Brenta, VI
commented
Assigned: Unassigned » robertoperuzzo
robertoperuzzo’s picture

robertoperuzzo
Primary language Italian
Location 🇮🇹 Tezze sul Brenta, VI
commented
StatusFileSize
new 3016988-1_php-incompatibility.patch239 bytes

I removed the following row from trailing_slash.info.yml

PHP: 7.1

and it seems to work like a charm.

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
commented
Status: Active » Needs review

Also note, if you do upgrade your hosting to PHP 7.2, Drupal's status report will incorrectly report PHP 7.1 due to this line.

What is the technical reason for requiring PHP 7.1, and can we remove that? PHP 7.1 will be EOL at the end of 2019.

Also note, Drupal 8 is only recommended to run on PHP 7.2 and 7.3 now https://www.drupal.org/docs/8/system-requirements/php-requirements

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
commented
Assigned: robertoperuzzo » Unassigned
dan612’s picture

dan612 commented
StatusFileSize
new php-incompatibility-3016988-6.patch1.46 KB

Patch as per reasoning in #4

chippyjacob’s picture

chippyjacob commented
Related issues: +#3077099: PHP Version on Status Report Shows Potentially Misleading Information

Patch provided in #6 is working for me. When I applied this patch, the issue https://www.drupal.org/project/drupal/issues/3077099 also become sorted out

chippyjacob’s picture

chippyjacob commented

Hi @dan612,

Is this patch approved?

parisek made their first commit to this issue’s fork.

parisek opened merge request !2

parisek’s picture

parisek
Primary language Czech
commented
Version: 8.x-1.0 » 8.x-1.x-dev

Updated patch against DEV version

parisek’s picture

parisek
Primary language Czech
commented
Status: Needs review » Reviewed & tested by the community

Working great, should be RTBC

astonvictor’s picture

astonvictor commented

Merged the MR.

astonvictor’s picture

astonvictor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.