Include the webform patch #2810913: Time component global default value.
Eventually we want the linked patch included in dvg. However that issue should be reworked before I'd commit it to dvg.
But that progress can be tracked in this issue.
This patch was originally added in #3013658: Add webform module patches for stricter submission access and auto uppercase textfields. But this webform patch needs some work first, unlike the other webform patches mentioned in 3013658. So I've opened this new issue so it is not the limiting factor for committing the other changes.
The newest patch now also includes the #3041384: Webform settings component fieldset is lost patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | interdiff-3-4.txt | 2.28 KB | paulvandenburg |
| #4 | dvg-add_webform_2810913_patch-3016143-4.patch | 1.95 KB | paulvandenburg |
Comments
Comment #2
paulvandenburg commentedThis patch requires the #2810913: Time component global default value issue to be applied first.
Also since the original patch needs work first I'll keep the status on needs work.
Comment #3
paulvandenburg commentedRenamed the patch according to standards. Which seems more important in this case due to 2 linked issues.
Comment #4
paulvandenburg commentedFixed the work that needed to be done in the related issue.
Then discovered another issue while doing that in webform. Which I've included here as well: #3041384: Webform settings component fieldset is lost
Added a migration from the old variable to the new one, as this patch was in use in a few sites.
Comment #5
johankleene commentedPatch applied and tested in a DvG instance. Fieldset and time global default setting work fine.
Comment #7
paulvandenburg commented