Currently, calculateDependencies() in FieldFormatterEntityEmbedDisplayBase has a vague @todo item. This function should be updated and if there is a @todo item, it should be made more specific.
/**
* {@inheritdoc}
*/
public function calculateDependencies() {
$this->addDependencies(parent::calculateDependencies());
$definition = $this->formatterPluginManager->getDefinition($this->getFieldFormatterId());
$this->addDependency('module', $definition['provider']);
// @todo Investigate why this does not work currently.
// $this->calculatePluginDependencies($this->getFieldFormatter());
return $this->dependencies;
}
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | entity-embed-fieldformatter-dependency-3015617-3.patch | 959 bytes | oknate |
Comments
Comment #2
oknate1) I was testing this a bit, and this line can be removed:
$this->addDependencies(parent::calculateDependencies());parent::calculateDependencies() returns an empty array from EntityEmbedDisplayBase()
2) Adding provider directly should be unnecessary, as $this->calculatePluginDependencies($this->getFieldFormatter()); will handle it, if calculateDependencies() method of that plugin is written correctly, so this should be removed:
proposed solution:
change to this:
Comment #3
oknateComment #4
oknateComment #5
phenaproxima"Doesn't work right"? Yeah, that's pretty vague. I think that, until it's clearer what the problem is, this is RTBC-able.
Comment #6
wim leersComment #7
wim leers#2587433: Add tests for embed button config dependencies introduced this.
Comment #8
wim leersActually, this issue is reporting the same problem as #2587433: Add tests for embed button config dependencies! And that was also intending to add test coverage. So this is just a duplicate :) Thanks for spotting the problem though!