Make sure that we're adding the following dependencies to the embed button config entity:
- The entity type provider module
- If bundles are checked, the bundle config entities
- If display plugins are checked, then the display plugin provider modules

Comments

Dave Reid created an issue. See original summary.

  • Dave Reid committed 8d438a8 on 8.x-1.x 
    Issue #2587433 by Dave Reid: Added more dependency calculations.
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Add tests for embed button config dependencies » [PP-1] Add tests for embed button config dependencies
Category: Feature request » Task
Status: Active » Postponed
Related issues: +#2328659: Convert all existing entity_embed tests from WebTestBase to BrowserTestBase

Similar to #2560787-3: Add tests for entity access.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: [PP-1] Add tests for embed button config dependencies » Add tests for embed button config dependencies
Status: Postponed » Active

Blocker is in.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Closed (duplicate)
Related issues: +#3015617: [config dependencies] Update calculateDependencies in FieldFormatterEntityEmbedDisplayBase

Closed this as a duplicate of #3015617: [config dependencies] Update calculateDependencies in FieldFormatterEntityEmbedDisplayBase.

oknate’s picture

oknate
Location Greater New York City Area
commented

I think this should be reopened. It's marked as a duplicate of #3015617: [config dependencies] Update calculateDependencies in FieldFormatterEntityEmbedDisplayBase and that is marked a duplicate of this and they are both closed.

Do we not need either issue? I think 3015617 addressed a lingering issue (there's a @todo) in FieldFormatterEntityEmbedDisplayBase ::calculateDependencies that should be addressed.