In the core skip_on_empty plugin there is an option to include a message:
public function row($value, MigrateExecutableInterface $migrate_executable, Row $row, $destination_property) {
if (!$value) {
$message = !empty($this->configuration['message']) ? $this->configuration['message'] : '';
throw new MigrateSkipRowException($message);
}
return $value;
}
It would be nice if we could do the same for SkipOnValue.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3015199-4.patch | 2.99 KB | marvil07 |
| #2 | 3015199-skiponvalue-message.patch | 2.95 KB | mstrelan |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mstrelan commentedComment #3
heddnCan we expand the tests to include this new optional feature?
Comment #4
marvil07 commentedRe-roll for 8.x-5.x
Comment #5
matroskeenWhile #3259591: Add generic Skip migrate process plugin with various operations is not ready yet, I think we can do it. Let's get some test examples from
SkipOnEmptyTestand get this in ;)We'll try to take care of it during the contribution weekend.
Comment #6
v.kydyba commentedComment #8
v.kydyba commentedComment #9
v.kydyba commentedComment #10
matroskeenThanks for the test, it looks great!
I noticed some inconsistency though. In
SkipOnEmptyplugin the message is added only for 'row' method. This behavior matches the plugin description:In
SkipOnValuethe description is the same, but message is added also in 'process' method.Is there any reason to add a message in 'process' method? I don't think so. Let's remove it and the update the tests.
Comment #12
matroskeenOops, it didn't squash commits properly 🙈
Anyway, now we have a message option that is aligned with
SkipOnEmptycore plugin.We also have test coverage, so let's get this in!
Thanks everyone!
Comment #15
matroskeenCrediting @AaronBauman for #3069682: Add a "message" configuration option for skip_on_value.