Problem/Motivation

#2961969: Set correct temp dir for DomPdf print engine added a new setting 'disable_log' for entity_print.print_engine.dompdf. However, this setting is not defined in entity_print.schema.yml

Proposed resolution

Add entity_print.print_engine.dompdf.settings.disable_log to entity_print.schema.yml

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 entity_print-disable_log_config_schema-3014768-2.patch877 bytesidebr

Issue fork entity_print-3014768

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new entity_print-disable_log_config_schema-3014768-2.patch877 bytes

Attached patch adds entity_print.print_engine.dompdf.settings.disable_log to entity_print.schema.yml

benjy’s picture

benjy commented
Status: Needs review » Needs work

It's a shame this never failed the tests, could you please add a test that flexes the config so we can pickup if we ever miss these again?

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3164576: Config schema incomplete for entity_print.print_engine.phpwkhtmltopdf:settings.zoom, +#3163208: Config schema incomplete for entity_print_views sub-module

It will be hard to create every variation of parameters to check every config schema

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

@benjy there's only 3 places broken, please suggest a way forward

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

This seems like a simple change and can confirm the issue using configuration_inspector. The whole schema could be validated but this is the only error in entity_print.print_engine.dompdf

smustgrave’s picture

smustgrave commented
Issue tags: +Needs Review Queue Initiative

claudiu.cristea made their first commit to this issue’s fork.

claudiu.cristea opened merge request !67

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

Moved patch from #2 to a MR

jsacksick made their first commit to this issue’s fork.

jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.