Problem/Motivation

We have some problems with config schema when using Print area in views

It is failing validation with Config inspector

cinsp failed

CommentFileSizeAuthor
#7 interdiff.txt675 bytessorlov
#7 entity_print-config_schema_missing-3163208-3019791.patch1.75 KBsorlov
#5 3163208-5.patch1.1 KBandypost
#2 entity_print-config_schema_missing-3163208-2.patch782 bytessorlov
cinsp.jpg72.66 KBsorlov

Issue fork entity_print-3163208

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sorlov created an issue. See original summary.

sorlov’s picture

sorlov commented
StatusFileSize
new entity_print-config_schema_missing-3163208-2.patch782 bytes

Patch to fix config schema for Print view area

sorlov’s picture

sorlov commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3014768: Missing config schema for entity_print.print_engine.dompdf.settings.disable_log
andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3163208-5.patch1.1 KB

Proper fix

- schema should be in entity_print_views.views.schema.yml (needs s/schema/views.schema suffix)
- additionally to area display also missing schema and could cause issues with saving areas' components (footer/header)

According the last bullet it may need update hook for existing sites (re-saving view helps)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Config schema missing for Print view area » Config schema incomplete for entity_print_views sub-module

Proper title

sorlov’s picture

sorlov commented
StatusFileSize
new entity_print-config_schema_missing-3163208-3019791.patch1.75 KB
new interdiff.txt675 bytes

Updated patch compatible with changes from https://www.drupal.org/project/entity_print/issues/3019791

andypost’s picture

andypost
he/him
Primary language Russian
commented

Last change is weird and makes patch non-commitable because mixing bugfix and changes from feature

jannakha made their first commit to this issue’s fork.

jannakha’s picture

jannakha commented
Status: Needs review » Needs work

please create merge request for faster review process