Allow custom files to be attached to emails and downloaded

This is getting really close the file naming looks to be working.
However I am occasionally getting the following error on submission. Not exactly sure the conditions that cause it.

The website encountered an unexpected error. Please try again later.</br></br><em class="placeholder">Drupal\Core\Entity\EntityStorageException</em>: Parameter &quot;filename&quot; for route &quot;entity.webform.user.submission.attachment&quot; must match &quot;[^/]++&quot; (&quot;20190110020130_Rental Property Owner/Manager_Authorization to  Allow Management Company to act on behalf of owner.xml&quot; given) to generate a corresponding URL. in <em class="placeholder">Drupal\Core\Entity\Sql\SqlContentEntityStorage-&gt;save()</em> (line <em class="placeholder">783</em> of <em class="placeholder">core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php</em>). <pre class="backtrace">Drupal\Core\Routing\UrlGenerator-&gt;getInternalPathFromRoute(&#039;entity.webform.user.submission.attachment&#039;, Object, Array, Array) (Line: 293)
Drupal\Core\Routing\UrlGenerator-&gt;generateFromRoute(&#039;entity.webform.user.submission.attachment&#039;, Array, Array, 1) (Line: 105)
Drupal\Core\Render\MetadataBubblingUrlGenerator-&gt;generateFromRoute(&#039;entity.webform.user.submission.attachment&#039;, Array, Array, 1) (Line: 753)
Drupal\Core\Url-&gt;toString(1) (Line: 167)
Drupal\Core\Utility\LinkGenerator-&gt;generate(&#039;20190110020130_Rental Property Owner/Manager_Authorization to  Allow Management Company to act on behalf of owner.xml&#039;, Object) (Line: 94)
Drupal\Core\Render\Element\Link::preRenderLink(Array)
call_user_func(Array, Array) (Line: 378)
Drupal\Core\Render\Renderer-&gt;doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer-&gt;render(Array) (Line: 490)
Drupal\Core\Template\TwigExtension-&gt;escapeFilter(Object, Array, &#039;html&#039;, NULL, 1) (Line: 51)
__TwigTemplate_29b41d9fed80b44f5f2a03f764defe940d5d4da6172995af1d26ead3a6607a06-&gt;doDisplay(Array, Array) (Line: 432)
Twig_Template-&gt;displayWithErrorHandling(Array, Array) (Line: 403)
Twig_Template-&gt;display(Array) (Line: 411)
Twig_Template-&gt;render(Array) (Line: 64)
twig_render_template(&#039;modules/webform/templates/webform-element-base-html.html.twig&#039;, Array) (Line: 384)
Drupal\Core\Theme\ThemeManager-&gt;render(&#039;webform_element_base_html&#039;, Array) (Line: 437)
Drupal\Core\Render\Renderer-&gt;doRender(Array) (Line: 450)
Drupal\Core\Render\Renderer-&gt;doRender(Array, 1) (Line: 195)
Drupal\Core\Render\Renderer-&gt;render(Array, 1) (Line: 151)
Drupal\Core\Render\Renderer-&gt;Drupal\Core\Render\{closure}() (Line: 582)
Drupal\Core\Render\Renderer-&gt;executeInRenderContext(Object, Object) (Line: 152)
Drupal\Core\Render\Renderer-&gt;renderPlain(Array) (Line: 842)
_webform_token_get_submission_values(Array, Object) (Line: 445)
webform_tokens(&#039;webform_submission&#039;, Array, Array, Array, Object)
call_user_func_array(&#039;webform_tokens&#039;, Array) (Line: 403)
Drupal\Core\Extension\ModuleHandler-&gt;invokeAll(&#039;tokens&#039;, Array) (Line: 304)
Drupal\Core\Utility\Token-&gt;generate(&#039;webform_submission&#039;, Array, Array, Array, Object) (Line: 196)
Drupal\Core\Utility\Token-&gt;replace(&#039;Submitted on [webform_submission:created]
Submitted by: [webform_submission:user]
Submitted values are:
[webform_submission:values]
&#039;, Array, Array, Object) (Line: 138)
Drupal\webform\WebformTokenManager-&gt;replace(&#039;Submitted on [webform_submission:created]
Submitted by: [webform_submission:user]
Submitted values are:
[webform_submission:values]
&#039;, Object, Array, Array, Object) (Line: 190)
Drupal\webform\WebformTokenManager-&gt;replaceNoRenderContext(&#039;Submitted on [webform_submission:created]
Submitted by: [webform_submission:user]
Submitted values are:
[webform_submission:values]
&#039;, Object, Array, Array) (Line: 928)
Drupal\webform\Plugin\WebformHandler\EmailWebformHandler-&gt;getMessage(Object) (Line: 856)
Drupal\webform\Plugin\WebformHandler\EmailWebformHandler-&gt;postSave(Object, , NULL) (Line: 2224)
Drupal\webform\Entity\Webform-&gt;invokeHandlers(&#039;postSave&#039;, Object, , NULL) (Line: 1097)
Drupal\webform\WebformSubmissionStorage-&gt;invokeWebformHandlers(&#039;postSave&#039;, Object, ) (Line: 1010)
Drupal\webform\WebformSubmissionStorage-&gt;doPostSave(Object, ) (Line: 432)
Drupal\Core\Entity\EntityStorageBase-&gt;save(Object) (Line: 774)
Drupal\Core\Entity\Sql\SqlContentEntityStorage-&gt;save(Object) (Line: 390)
Drupal\Core\Entity\Entity-&gt;save() (Line: 757)
Drupal\webform\Entity\WebformSubmission-&gt;save() (Line: 1637)
Drupal\webform\WebformSubmissionForm-&gt;save(Array, Object)
call_user_func_array(Array, Array) (Line: 111)
Drupal\Core\Form\FormSubmitter-&gt;executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter-&gt;doSubmitForm(Array, Object) (Line: 589)
Drupal\Core\Form\FormBuilder-&gt;processForm(&#039;webform_submission_contact_us_add_form&#039;, Array, Object) (Line: 318)
Drupal\Core\Form\FormBuilder-&gt;buildForm(&#039;webform_submission_contact_us_add_form&#039;, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder-&gt;getForm(Object, &#039;add&#039;) (Line: 1046)
Drupal\webform\Entity\Webform-&gt;getSubmissionForm() (Line: 84)
Drupal\webform\Controller\WebformEntityController-&gt;addForm(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;Drupal\Core\EventSubscriber\{closure}() (Line: 582)
Drupal\Core\Render\Renderer-&gt;executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel-&gt;handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel-&gt;handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle-&gt;handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache-&gt;pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware-&gt;handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware-&gt;handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel-&gt;handle(Object, 1, 1) (Line: 669)
Drupal\Core\DrupalKernel-&gt;handle(Object) (Line: 19)
</pre>

Also is there any way to enhance the phone field validation. Currently is allows anything as a phone number.

The sanitation flag lets the form submit but it strips the date I have configured at the beginning.

I discovered the issue with submitting is with the drop downs containing '/'.

Additionally, if you submit a form that had a file name that would have erred if not for the sanitation flag. Then you disable the flag, the 'result' page errors until you re-enable the flag.

That's what I was thinking.
Is it a requirement as part of sanitation the lower casing of all the characters?

Is patch 39 OK to test?

The sanitation error looks to be mitigated, however sanitizing still strips the date.

The literal values of the two fields that append the file name
"Rental Property Owner/Manager"
"Authorization to Allow Management Company to act on behalf of owner"

File Name configuration:

[webform_submission:completed:custom:Ymdhis]_[webform_submission:values:category:raw]_[webform_submission:values:sub_moving:raw][webform_submission:values:sub_budget:raw][webform_submission:values:sub_billing_question:raw][webform_submission:values:sub_refund:raw][webform_submission:values:sub_rental_prop_owner_manager:raw][webform_submission:values:sub_web_administration:raw][webform_submission:values:sub_payments:raw][webform_submission:values:sub_energy_assistance:raw][webform_submission:values:sub_letter_received:raw]_webform.xml

Filename result with sanitize not checked

20190111112153_Rental Property OwnerManager_Authorization to  Allow Management Company to act on behalf of owner_webform.xml

Filename result with sanitize checked

manager_authorization-to-allow-management-company-to-act-on-behalf-of-owner_webform.xml

Email Subject field length needs to be increased. Similar issue as with file name. Once I start adding in potential token values, the field truncates.

This is what I'm trying to currently use as a email subject.
Website_ContactUsForm_[webform_submission:completed:custom:Ymdhis]_[webform_submission:values:category:raw]-[webform_submission:values:sub_budget_bill:raw][webform_submission:values:sub_bill_amount:raw][webform_submission:values:sub_refund:raw][webform_submission:values:sub_payment:raw][webform_submission:values:sub_web_admin:raw][webform_submission:values:sub_miscellaneous:raw]

Clicking edit on a field set as required doesn't perpetuate the required status into the edit box. Will disable if saved without re-selecting.

In this case (see attached image), if I click edit on this select (that is currently set as required), the edit panel doesn't have 'required' selected. If I click save without making any change, it will no longer be required.

Doesn't make a difference. If I save in main screen or save in edit panel, as soon as I edit the field it is always deselected.

Yes, this is exactly what has been done. The state is saved, I can go away from that form and reopen it and the required state is selected, however as soon as I click edit, the edit panel does not have required selected at the bottom under 'Form Validation'.

Both fixes appear to be working, however custom required text no longer displays. The required fields will focus but no text. (remember this is a case where two fields are conditionally required, one or the other).

What is the format of the token to write the attachment into the body of a custom message format.
Tried
[webform_submission:values:sap_contact_us_results_xml]

But it just wrote it verbatim into the body.

A link would have been fine.

Should [webform_submission:values:sap_contact_us_results_xml] have written the link?

I was about to file a new issue where the 'Resend' option generated an error for a custom file that is being attached with a custom EmailWebformHandler when I stumbled upon this issue. After applying the patch in #53 the form is working again beautifully!

Many thanks @jrockowitz for your great work!