Problem/Motivation
The Drupal and DrupalPractice request depency injection

Proposed resolution
Inject objects \Drupal\Core\Entity\EntityManager

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 webform-dependency_injection_on_WebformAccessGroupForm-3013437-2.patch3.07 KBthalles
#2 webform-dependency_injection_on_WebformAccessGroupForm-3013437.patch2.77 KBthalles

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new webform-dependency_injection_on_WebformAccessGroupForm-3013437.patch2.77 KB

Follow the patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
jrockowitz’s picture

jrockowitz commented 
+++ b/modules/webform_access/src/WebformAccessGroupForm.php
@@ -57,12 +65,15 @@ class WebformAccessGroupForm extends EntityForm {
     $this->database = $database;
     $this->elementManager = $element_manager;
     $this->webformEntityReferenceManager = $webform_entity_reference_manager;
     $this->webformAccessRulesManager = $webform_access_rules_manager;
+    $this->entityManager = $entity_manager;

The entity.manager service should come after the database service.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I will correct it soon!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new webform-dependency_injection_on_WebformAccessGroupForm-3013437-2.patch3.07 KB

Follow the patch!

  • jrockowitz committed 76fdb5d on 8.x-5.x authored by Thalles 
    Issue #3013437 by Thalles: Drupal dependency injection on modules/...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.