When visiting the theme settings page the saved text format for the "Title bar" field is not used.

Besides that, I've seen that the theme uses the "old" style of array syntax. For Drupal 8 the short array syntax should be used.

See the attached patch (next comment) for the solutions.

CommentFileSizeAuthor
#6 bootstrap_rijkshuisstijl-title-bar-format-fix-3012617-6.patch1023 bytesmartijn de wit
#5 bootstrap_rijkshuisstijl-title-bar-format-fix-3012617-5.patch1 KBfabianderijk
#2 bootstrap_rijkshuisstijl-title-bar-format-fix-3012617-2.patch15.49 KBfabianderijk

Comments

fabianderijk created an issue. See original summary.

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Assigned: fabianderijk » Unassigned
Status: Active » Needs review
StatusFileSize
new bootstrap_rijkshuisstijl-title-bar-format-fix-3012617-2.patch15.49 KB

See the attached patch

martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented

Hey Fabianderijk,

Thank you for the patch. Can we easy split out de array syntax and the real issue? So we get a cleaner commit and review process.

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented

Of course I can. I'll add two new patches later.

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
StatusFileSize
new bootstrap_rijkshuisstijl-title-bar-format-fix-3012617-5.patch1 KB

This is the new patch for the format fix. I'll create a new issue for the array syntax fix and base that on the 8.x-1.x branch without this fix.

martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
StatusFileSize
new bootstrap_rijkshuisstijl-title-bar-format-fix-3012617-6.patch1023 bytes

Removed an double ,
I will commit this at the develop branch. Thank you!

  • Martijn de Wit committed 115b5ed on 8.x-1.x 
    Issue #3012617 by fabianderijk, Martijn de Wit: Title bar text formatted...
martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Needs review » Reviewed & tested by the community
martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.