Problem/Motivation

\Drupal\webform\Form\WebformContributeForm injects RouteBuilderInterface and CacheBackendInterface, but does not use them.

Proposed resolution

Remove dependency injection for RouteBuilderInterface and CacheBackendInterface in \Drupal\webform\Form\WebformContributeForm

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 webform-contribute_form_unused_dependencies-3012357-2.patch3.15 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new webform-contribute_form_unused_dependencies-3012357-2.patch3.15 KB

Attached patch removes RouteBuilderInterface and CacheBackendInterface from the dependency injection in \Drupal\webform\Form\WebformContributeForm

jrockowitz’s picture

jrockowitz commented

You just made me smile because you are looking at the Contribute code.

idebr’s picture

idebr commented

Hah! And now I made you look too.

  • jrockowitz committed 4c45bcb on 8.x-5.x authored by idebr 
    Issue #3012357 by idebr: \Drupal\webform\Form\WebformContributeForm...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Committed. Thanks for contributing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.