Problem/Motivation

Coding standards

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 webform-coding_standards-3010873.patch1.63 KBthalles

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new webform-coding_standards-3010873.patch1.63 KB

Congratulations for your work!
Follow the patch!

jrockowitz’s picture

jrockowitz commented

@Thalles Thanks for the patch.

I do code reviews before each release. There is no way webform can follow all of Drupa's coding standards. A more valuable and much needed contribution is reviewing the UI for grammatical mistakes.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Fixed
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I can try, but my english is very weak!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Do you prefer that you no longer have Coding Standards?

jrockowitz’s picture

jrockowitz commented

Yes, I follow Drupal's coding standards.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Sorry, that's not what I meant. I looked at your module and I could see that you are very careful, what I wanted to ask is if you would prefer that I did not post more coding standards patch at that time?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.