Problem/Motivation

CreditCard::calculateExpirationTimestamp returns the unix timestamp for the beginning of last day in the month. This makes all payment method created with the help of that method to be expired before the formal end of the month.

Proposed resolution

Swap strtotime with mktime and calculate unix timestamp for 23:59:59.

CommentFileSizeAuthor
#2 3010509-2.patch1.16 KBzaporylie

Comments

zaporylie created an issue. See original summary.

zaporylie’s picture

Status: Active » Needs review
StatusFileSize
new1.16 KB

Swap strtotime with mktime and calculate unix timestamp for 23:59:59.

This patch does exactly that + changes corresponding test.

  • bojanz committed ba5bb0e on 8.x-2.x authored by zaporylie
    Issue #3010509 by zaporylie: CreditCard::calculateExpirationTimestamp...
bojanz’s picture

Status: Needs review » Fixed

Tests don't help when they confirm the wrong behavior :) Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.