Add dependency on slevomat/coding-standard

This already exists in https://github.com/slevomat/coding-standard/#slevomatcodingstandardcontr...

Added link to PR to issue summary - https://github.com/pfrenssen/coder/pull/147

Checked the pull request and left a comment there, I think we should do more than just adding the dependency.

Committed, thanks! This bumps Coder's PHP minimum version to 7.1, but I think that is fine (PHP 7.0 has been end of life for 3 years now). Users with older PHP versions can still use the previous Coder version.

Please open new issues to enable and configure more sniffs for the selvomat coding standard. Please also add minimal test cases to bad.php so that we know the inclusion actually works.

We use PHP Codesniffer + Coder in our automated testing workflow to check coding standards, and today phpcs has started failing with:

Referenced sniff "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" does not exist

I found this issue while trying to investigate... is it related? Has anyone else encountered this?

Facing the same issue: ERROR: Referenced sniff "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" does not exist

The same error as #10 and #11

Experimenting with

COMPOSER_MEMORY_LIMIT=-1 composer global require slevomat/coding-standard:^7.0
COMPOSER_MEMORY_LIMIT=-1 composer global require drupal/coder:^8.3.10
phpcs --config-set installed_paths ~/.config/composer/vendor/drupal/coder/coder_sniffer,~/.config/composer/vendor/slevomat/coding-standard

No luck so far.

This issue occurs when the Coder standards are loaded, but the Slevomat standard isn't. We're currently using dealerdirect/phpcodesniffer-composer-installer to automatically set the installed_paths on Composer install. When using Composer 2.2 or higher, Composer will ask for your permission to allow this plugin to execute code. For this plugin to be functional, permission needs to be granted. Which will result in the following config in the composer.json

"config": {
    "allow-plugins": {
        "dealerdirect/phpcodesniffer-composer-installer": true
    }
},

This issue will also occur when phpcs --config-set installed_paths is executed after the composer install without including the Slevomat standard, as it will overwrite the automatically set installed_paths.

The workaround of #13 will also fix this issue, but make sure to use absolute paths, as ~ will only work on the first standard. So taking the previous example, use:

phpcs --config-set installed_paths 
 /home/lorem/.config/composer/vendor/drupal/coder/coder_sniffer,/home/lorem/.config/composer/vendor/slevomat/coding-standard

Just confirming that #13 and #14 worked to resolve the issue identified in #10

ERROR: Referenced sniff "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" does not exist

1) Even though it's a dependency ensure that slevomat is installed

composer require slevomat/coding-standard:^7.0

2) Update the config sets loaded

phpcs --config-set installed_paths /var/www/vendor/drupal/coder/coder_sniffer,/var/www/vendor/slevomat/coding-standard

3) code sniff & profit

phpcs --standard=Drupal --extensions='inc,php,module' --error-severity=1 --warning-severity=8 web/modules/custom -s

@aczietlow

Thank you for summarizing the points. It helped and worked for me resolving the same error. Thanks!

The explanation here makes sense, but I wonder if it should have been classed as a breaking change and therefor a major update.

This issue was flagged for me when dependabot tried to do an upgrade of coder. I'm not sure if I would expect a minor upgrade to require a change to the build script.

It's too late now, but perhaps worth considering in future.

I found removing an extra <config name="installed_paths" in my phpcs.xml resolved the issue.

dealerdirect/phpcodesniffer-composer-installer was already included in the project, and added to the allow-plugins entry.

Adding the correct `installed_paths ` from #15 worked for me.