The module is using administer users permission which is too general.

In a use case where a role needs to be restricted (by using the roleassign module for example) this module can bypass the restriction.

I'm proposing an explicit permission for this module.

CommentFileSizeAuthor
#5 3010025-5.patch994 bytesyogen.prasad
#2 3010025.patch777 bytesefpapado

Comments

efpapado created an issue. See original summary.

efpapado’s picture

efpapado commented
Status: Active » Needs review
StatusFileSize
new 3010025.patch777 bytes

Attaching patch

mlncn’s picture

mlncn commented

Looks excellent; i'm in favor. Because we do have a tagged beta, not just an alpha or dev, i think it's necessary to provide an update hook enabling this new permission for any roles that have the old, 'administer users' permission.

efpapado, are you up for that?

yogen.prasad’s picture

yogen.prasad commented
Assigned: Unassigned » yogen.prasad
yogen.prasad’s picture

yogen.prasad commented
StatusFileSize
new 3010025-5.patch994 bytes

Hi All,

Added changes suggested by mlncn .

Thanks

yogen.prasad’s picture

yogen.prasad commented
Assigned: yogen.prasad » Unassigned
efpapado’s picture

efpapado commented

Very nice, thank you!

I would like to ask you to give me an attribution for the patch please :)
You can see some instructions here: https://www.drupal.org/node/1146430

yogen.prasad’s picture

yogen.prasad commented

Hi efpapado,

As the maintainer of the module, i had pushed the code changes to active dev branch i,e : 8.x-1.x.

I think patch i not requited in this case.

Please let me know if we still need the patch.

Thanks

efpapado’s picture

efpapado commented

Hi efpapado,
As the maintainer of the module, i had pushed the code changes to active dev branch i,e : 8.x-1.x.
I think patch i not requited in this case.
Please let me know if we still need the patch.

This is great!
When you are submitting code that someone else wrote (either you apply the patch, or you just write it manually) it's a nice gesture to give attribution to the person that wrote this code, so that his efforts are logged and recognised :)
You can find instructions here: https://www.drupal.org/node/1146430

karthikeyan-manivasagam’s picture

karthikeyan-manivasagam commented
Status: Needs review » Fixed

Thank you @efpapado @yogen.prasad

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.