Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Order
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Oct 2018 at 15:51 UTC
Updated:
10 Jun 2020 at 21:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
khiminrm commentedComment #3
khiminrm commentedComment #5
khiminrm commentedComment #6
khiminrm commentedComment #7
bojanz commentedNo reason not to add this template.
Problems:
1. We don't prefix our entities and render arrays with commerce_ in templates. So we want just order_item and order_item_entity.
2.
I don't think we should do this. The template can easily do {{ order_item_entity.getPurchasedEntity.getProduct.something }} when needed.
Comment #8
khiminrm commented@bojanz, thanks for your help!
I've created new patch using your suggestions.
Comment #9
khiminrm commentedComment #10
niklanThank you for the provided patch.
The patch works as expected, but there is a mistake made in #8. The theme variables became "order_item" but in template still used "commerce_order_item". So, I changed in patch #8 and sure it can be marked as RTBC.
Comment #11
martijn de witBoth patches don't apply any more.
Comment #12
staalex commentedSame patch with updated line index, should apply cleanly now.
Comment #13
staalex commentedWhitespace issue on previous patch
Comment #14
staalex commentedPatch now applies cleanly, moving back to RTBC
Comment #15
majmunbog commentedConfirming the patch #13 works fine.
Comment #17
mglamanThanks! 🥳 commited.