entityManager is deprecated and should be replaced.

CommentFileSizeAuthor
#2 entitymanager_is_deprecated-3009100-02.patch657 bytesvisabhishek

Comments

visabhishek created an issue. See original summary.

visabhishek’s picture

visabhishek commented
Status: Active » Needs review
StatusFileSize
new entitymanager_is_deprecated-3009100-02.patch657 bytes

Uploading initial patch

rudranil29’s picture

rudranil29 commented
Status: Needs review » Reviewed & tested by the community

Working fine... tested on my system...

rudranil29’s picture

rudranil29 commented
Assigned: Unassigned » rudranil29

Working fine... tested on my system...

rudranil29’s picture

rudranil29 commented
Assigned: rudranil29 » Unassigned
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

Thanks for the contribution, Apparently we can use this https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Assigned: Unassigned » rakesh.gectcr
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Reviewed & tested by the community » Fixed

Thank you so much!

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Issue tags: +DIACWMay2020
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: rakesh.gectcr » Unassigned
Status: Fixed » Reviewed & tested by the community
Issue tags: +Drupal 9 compatibility, +Drupal 9 porting weekend

This is marked fixed but no code was committed. Moving back to RTBC. Also adding relevant tags.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Reviewed & tested by the community » Fixed

Hmm... maybe this was fixed? I see a commit in the commit log. Normally a commit comment would show up in this issue like this:

https://www.drupal.org/project/galleryslider/issues/3139135#comment-1363...

How are you committing these patches?

(p.s. sorry for the noise... it took me 3 issues before I realized that there was something else going on.)

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Fyi, after discussing this with others, it appears that because this issue is for a different version (branch) than what the code was committed to, the commit comment won't show up here. You could probably get the commit to show up by 1) moving this back to RTBC, 2) switching the version to 2.0.0 (now that it exists), and 3) marking Fixed again. Never mind, I forgot that the commit comment happens during the commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.