The read only notice uses css classes messages warning, warning should be changed to messages--warning to replicate the style of a real message. On the other hand, could this not be changed to use drupal_set_message(), or more importantly the new \Drupal::messenger() service?

CommentFileSizeAuthor
#4 3008741-4.readonlymode.Fix-readonly-notice-message-styling.patch542 bytessingularo
#3 3008741-3.patch544 bytesacbramley
#2 3008741-2.patch556 bytesacbramley

Issue fork readonlymode-3008741

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley commented
Status: Active » Needs review
StatusFileSize
new 3008741-2.patch556 bytes

Quick fix to the current markup.

acbramley’s picture

acbramley commented
StatusFileSize
new 3008741-3.patch544 bytes

Reroll against latest dev

singularo’s picture

singularo
Location Adelaide, AUS
commented
StatusFileSize
new 3008741-4.readonlymode.Fix-readonly-notice-message-styling.patch542 bytes

Update patch to work with latest release.

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented

Is there any reason this isn't using the core messenger service to display this message, or at least a render array of '#type' => 'status_messages'? The current implementation doesn't allow themes to use their own message templates or preprocess functions, and libraries don't get attached.

Ambient.Impact opened merge request !5

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented

Created a quick merge request to use '#theme' => 'status_messages' for the message, which should fix all our problems.

altcom_neil’s picture

altcom_neil commented
Related issues: +#3372900: Add a hook to alter the form when read only mode is enabled

astonvictor made their first commit to this issue’s fork.

astonvictor changed the visibility of the branch 3008741-notice to hidden.

astonvictor’s picture

astonvictor commented
Status: Needs review » Reviewed & tested by the community

Fixed some minor issues in the MR and pulled new changes.

While testing found that we use a 'string' schema for messages. I guess it should be changed to the 'label' type to allow users to translate messages in the config. I think it should be added in a separate task.

sharique made their first commit to this issue’s fork.

sharique’s picture

sharique commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.