Complete the deprecation of format_date()

This adds $date_formatter = $this->container->get('date.formatter') in a few more places. Including adding it to FilterDateTest::setup() since the date formatter is used in most of its methods. Hope that is useful.

+++ b/core/modules/locale/tests/src/Functional/LocaleUpdateInterfaceTest.php
@@ -111,7 +111,10 @@ public function testInterface() {
+      '@date' => $this->container->get('date.formatter')->format(REQUEST_TIME, 'html_date'),

while thisline changed it needs to use date service instead of deprecated REQUEST_TIME

Addresses #8.

The splitting of issues like

• #3008446: Complete the deprecation of format_date()
• #3008493: Deprecate format_date() in classes
• #3008494: Deprecate format_date() in core .modules and .inc files

is against the advice of our scoping recommendations. Let's not do this. See https://www.drupal.org/core/scope

I'm going to combine all the issues to the earliest issue - #3008446: Complete the deprecation of format_date()

Combining all the patches. All the people who have worked on the other issues are already credited here.

A few minor improvements

+++ b/core/modules/views/src/Plugin/views/argument/DayDate.php
@@ -20,22 +20,25 @@ class DayDate extends Date {
   /**
-   * Provide a link to the next level of the view
+   * {@inheritdoc}
    */
...
   /**
-   * Provide a link to the next level of the view
+   * {@inheritdoc}
    */
...
+  /**
+   * {@inheritdoc}
+   */

+++ b/core/modules/views/src/Plugin/views/argument/FullDate.php
@@ -20,18 +20,18 @@ class FullDate extends Date {
   /**
-   * Provide a link to the next level of the view
+   * {@inheritdoc}
    */
...
   /**
-   * Provide a link to the next level of the view
+   * {@inheritdoc}
    */

+++ b/core/modules/views/src/Plugin/views/argument/MonthDate.php
@@ -20,21 +20,24 @@ class MonthDate extends Date {
   /**
-   * Provide a link to the next level of the view
+   * {@inheritdoc}
    */
   public function summaryName($data) {
...
   /**
-   * Provide a link to the next level of the view
+   * {@inheritdoc}
    */
...
+  /**
+   * {@inheritdoc}
+   */

These changes are of questionable scope. However I think it is okay for some of them to remain because, where we are changing the return of the method, updating the docblock is okay. But the changes to add a docblock to summaryArgument are not in scope.

+++ b/core/modules/content_translation/src/ContentTranslationHandler.php
@@ -503,13 +515,17 @@ public function entityFormAlter(array &$form, FormStateInterface $form_state, En
-      $date = $new_translation ? REQUEST_TIME : $metadata->getCreatedTime();
+      $request_time = \Drupal::time()->getRequestTime();
+      $date = $new_translation ? $request_time : $metadata->getCreatedTime();

+++ b/core/modules/locale/tests/src/Functional/LocaleUpdateInterfaceTest.php
@@ -104,14 +104,17 @@ public function testInterface() {
-    $status['drupal']['de']->files['local']->timestamp = REQUEST_TIME;
+    $status['drupal']['de']->files['local']->timestamp = \Drupal::time()->getRequestTime();

That's a little bit out of scope. But I'm okay with that, as there too much not replaced REQUEST_TIME yet.

Anyway tests are green, and all calls and mentions are properly replaced. +1 for RTBC

Yeah the out-of-scope changes kind of bother me. We really only should be changing things directly in-scope. Especially in run-time code. I realise this was requested in #8 but that it incorrect. Scoped issues that address only one thing are important because when and if things need rolling-back or discussed at a later date makes it easier to make sense. The changes to system.tokens.inc show why this is important - we were still using REQUEST_TIME in this file after #14 - inconsistencies like this become confusing.

If this patch was ready to go I would say that we should just go forward and not fix REUQEST_TIME, BUT we have no deprecation test which is required because:

• To ensure the deprecation is triggered as expected
• To ensure we don't break format_date() as a later date in the Drupal 8 cycle.

Looks much better this time. The legacy test also looks good. +1 for rtbc.

Needed a re-roll after #3019834: Add @trigger_error() to deprecated url/link EntityInterface methods

Great! RTBC again

Committed 31f9ebf and pushed to 8.7.x. Thanks!

Also thanks for keeping the scope in check here, especially for a New Years Day commit.