The submit button is not following any condition while in popup/dialogs

Here is a patch. I think this is about any form put in dialog not just webforms so this is really Major.

The patch applied clean to latest 8.8.x-dev

@alonaoneill could please describe why it needs reroll and what you are looking for.

The patch applies fine over 8.8.x.

Sorry, my mistake. Didn't apply for me first time, but then did!

Setting back to Needs Review as per above comments.

Not working (Drupal 8.9.2)

Added a patch for 9.1.x

Tested patch #21 on 9.1.x but issue is still there. Button is not getting hidden on condition. Attaching screenshot of modal after applying patch.

Tested #21, I am also facing the same issue mentioned in #22
Please check

hi all, are there any hopes of sorting this issue out? I would look into it myself, but I'm afraid this #states stuff is still a bit out of my league at the moment :/

Work around with drupalAutoButton = FALSE.

Need this patch, though: https://www.drupal.org/project/drupal/issues/2793343

Re-rolled #21 for 9.4.

Updated patch will resolves CSpell errors.

Verified the issue by applying the patch, patch was successfully applied.

Steps to Reproduce -
1. Go to the terminal -> Apply the patch
2. Install the webform.
3. Copy the git link using below link.
https://www.drupal.org/project/webform/git-instructions
4. Copy the webform module in the modules folder under Drupal.
5. Go to the site.
6. Go to /admin/modules
7. Enable the web forms and webform UI.
8. Go to /admin/structure/webform/manage/contact/source
9. Paste the below code
name:
'#type': textfield
'#title': 'Your Name'
'#placeholder': 'Hide Button'
'#required': true
'#states':
invisible:
':input[name="name"]':
value: 'Hide Button'
'#default_value': '[current-user:display-name]'
email:
'#title': 'Your Email'
'#type': email
'#required': true
'#default_value': '[current-user:mail]'
subject:
'#title': Subject
'#type': textfield
'#required': true
'#test': 'Testing contact webform from [site:name]'
message:
'#title': Message
'#type': textarea
'#required': true
'#test': 'Please ignore this email.'
actions:
'#type': webform_actions
'#title': 'Submit button(s)'
'#submit_hide': true
'#submit__label': 'Send message'
10. Go to /admin/structure/webform/manage/contact
11. Mark the Your Name as hidden
12. Go to /admin/structure/types/manage/article/fields/node.article.field_test_menu
13. Create the article
14. In the body field, Enter the text as "

Open article

"
15. Save the article.
16. Copy the node link.
17. Open in incognito window.
18. Verify.

Before Patch -

After Patch -

Re-rolled patch#30 for 9.5.x. Thanks @yogeshmpawar

Applied patch #34 on 9.5.x-dev.

Test Result:
Patch applied successfully but issue is not resolved. 'Send Message' Button is not getting hidden on condition when webform is launched in modal pop-up.

Attaching screenshot of modal after applying patch

Moving to Need Work

Re-roll for core 9.5.1.

Re-roll for 10.1.x

I have fixed the failures also attached interdiff for same. please review

The IS appears to be missing the proposed solution.

Also should add a test case showing the issue.

Sharing my very naive alternative patch (on top of 10.2.x), maybe this can help some of you.

Any chance for a Drupal 11 MR?

The previous implementation triggered dialogButtonsChange events on every form element state change (disabled, readonly, required, visible, checked, collapsed), causing dialog buttons to be recreated too frequently. This created a race condition where tests tried to interact with buttons while they were being recreated, resulting in "element not interactable" errors.

Changes:
- Updated dialog.ajax.js to use button.disabled property instead of getAttribute('disabled') to return proper boolean values for jQuery UI
- Modified states.js to only trigger dialogButtonsChange when submit buttons themselves change state (disabled or visible), not for every form element
- Other state handlers (readonly, required, checked, collapsed) don't trigger button updates as they don't apply to submit buttons

Thanks for picking up!

Can the summary be updated to use the standard template
Was previously tagged for tests which will still be needed

It does not work for me

It is fine when the web form is visited directly.
However, when it is opened as a modal, the button is not hidden.

Sorry this one needs a rebase please.

Leaving IS update tag as the proposed solution is talking about fixing an es6 file which we know isn't the case