create_function is deprecated as of PHP 7.2, so it should be removed from function scald_rendered_to_sas

CommentFileSizeAuthor
#3 3007118-3-PHP-7.2-compat.patch1.37 KBDeFr

Comments

Rudi Teschner created an issue. See original summary.

rudi teschner’s picture

rudi teschner commented
Issue summary: View changes
DeFr’s picture

DeFr commented
Status: Active » Needs review
StatusFileSize
new 3007118-3-PHP-7.2-compat.patch1.37 KB

As far as I can tell, we're still supporting PHP 5.2, so we can't change that call to a pure anonymous function as introduced by PHP 5.3.

I think the best way forward is thus the attached patch, creating a real function for the callback.

rudi teschner’s picture

rudi teschner commented

Wow that was fast :D

I agree, no need to risk downward-compatibility.

dan_metille’s picture

dan_metille commented

@DeFr Thanks, patch #3 worked well for me!

  • nagy.balint committed 36d0717 on 7.x-1.x authored by DeFr 
    Issue #3007118 by DeFr, Rudi Teschner, sahaj: PHP 7.2 Support
nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Thanks!

I did a quick test with and without the patch on php7.1 and i got the same output from the function.

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.