When using Drupal 6.45 with PHP 7, the Views Attach module produces the following warning due to incompatible declarations:

warning: Declaration of views_attach_plugin_display_node_content::options_submit($form, &$form_state) should be compatible with views_plugin_display::options_submit(&$form, &$form_state) in /Users/tce/Sites/drupal-6.45/sites/all/modules/views_attach/views_attach_plugin_display_node_content.inc on line 0.

This has been fixed by the Form Fixes commit on 2017-03-21. This should be released as a follow-up to the drupal-6.45 release.

Comments

Tom Elwertowski created an issue.

micahw156’s picture

micahw156
he/him/his
commented

This was fixed in https://www.drupal.org/commitlog/commit/8458/109fb1aab4213f6302a3dab0b4e... and is already in views_attach 6.x-2.x branch

See also: https://cgit.drupalcode.org/views_attach/commit/?id=109fb1a

The real solution here might be to just confirm that everything committed since 6.x-2.2 is stable enough to call it a release.

FWIW, I've been running the 6.x-2.2+11-dev version (up through https://cgit.drupalcode.org/views_attach/commit/?h=6.x-2.x&id=9e7f652 commit) for over a year in production with no problems.

Not changing issue status here, because I do believe some kind of decision needs to be made, but the patch is already done.