Problem/Motivation

With "Advanced HTML/Text" field, richtext editor enabled, when I upload an inline-image, the field is stored in temporary mode in database. When cron task is enabled, the file is deleted when core detects the defined temporary time file is reached.

CommentFileSizeAuthor
#11 inline-image-is-stored-as-temporary-file.patch1.41 KBChetanac
#7 3005297-7.patch1.41 KBFlorent Jousseaume
#6 3005297-6.patch1.42 KBjrockowitz
#6 interdiff-3005297-5-6.txt652 bytesjrockowitz
#5 3005297-5.patch1.31 KBFlorent Jousseaume
#3 3005297-3.patch1.34 KBFlorent Jousseaume
#2 3005297-2.patch1.31 KBjrockowitz

Comments

Florent Jousseaume created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 3005297-2.patch1.31 KB
Florent Jousseaume’s picture

Florent Jousseaume commented
StatusFileSize
new 3005297-3.patch1.34 KB

Hi !

I have a problem with your patch. Values are double quoted (\"file\" for example), so comparison between 'file' and '\"file\"' does not work. The UUID has the same problem, so I added a trim for each value. I don't know if it is a good practice, but I did not see something like that in DomXXXX class.

jrockowitz’s picture

jrockowitz commented 
+++ b/includes/webform.editor.inc
@@ -238,12 +238,27 @@ function _webform_parse_file_uuids($text) {
+      $img = str_replace('\\\\\"', '"', $img);

Can we improve this cleanup code instead of fixing the attributes?

Florent Jousseaume’s picture

Florent Jousseaume commented
StatusFileSize
new 3005297-5.patch1.31 KB

Sorry... I just looked to the values... here is a new version.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new interdiff-3005297-5-6.txt652 bytes
new 3005297-6.patch1.42 KB

Of course, now I see that "there is a PHP function for that".

@see stripslashes()

Florent Jousseaume’s picture

Florent Jousseaume commented
StatusFileSize
new 3005297-7.patch1.41 KB

Hello, it seems OK for me, after testing it on my local environment.
I just modified the comment before stripslahes() methods.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

@Florent Jousseaume Thanks for the help.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Chetanac’s picture

Chetanac commented
StatusFileSize
new inline-image-is-stored-as-temporary-file.patch1.41 KB

This file is for webfom 6.0.3 .