According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | Update_dependencies_format_in_info.yml_3005175-9.patch | 320 bytes | chipway |
| #6 | oauth2_server-infofile-3005175-6.patch | 319 bytes | volkswagenchick |
Comments
Comment #2
volkswagenchickI uploaded a patch that aligns the dependency namespacing to Drupal standards. Thanks!
Comment #3
volkswagenchickI just noticed an empty space. patch forthcoming!
Comment #4
volkswagenchickOkay updated the patch. Please review
Comment #5
volkswagenchickok - This one is really the right one :)
Comment #6
volkswagenchickugh. ok - let's try this one last time :)
Comment #7
alonaoneill commentedCode looks good. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Thank you for working on module!
Comment #8
chipway commentedPatch applies but it lacks a space.
Comment #9
chipway commentedHere is the new patch. Please review.
Comment #10
volkswagenchickThe code looks good. The dependency namespacing was addressed. Patch applied using simplytest.me
Marking RTBC, and thanks for the fix @chipway. Good catch.
Comment #11
sanduhrsComment #14
sanduhrsCommitted, thanks!
Comment #16
sanduhrs