Problem/Motivation

Some Warning and errors of default Drupal

Proposed resolution

Format code and comments

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#29 interdiff-26-29.txt9.33 KBelaman
#29 3003707-29.patch15.58 KBelaman
#26 coding_standards-3003707-25.patch13.34 KBpatelmayank7552
#19 taxonomy_menu-Coding_standards-3003707-19-D8.patch10.33 KBkaran sen
#17 taxonomy_menu-Coding_standards-3003707-17-D8.patch15.34 KBthalles
#14 taxonomy_menu-Coding_standards-3003707-14-D8.patch15.31 KBthalles
#9 taxonomy_menu-3003707-8.patch13.28 KBSnehal Brahmbhatt
#4 coding_standards-taxonomy_menu-3003707-2.patch14.97 KBthalles
#2 coding_standards-taxonomy_menu-3003707.patch14.1 KBthalles

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new coding_standards-taxonomy_menu-3003707.patch14.1 KB

Hi, follow a litle conttribution

Status: Needs review » Needs work

The last submitted patch, 2: coding_standards-taxonomy_menu-3003707.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new coding_standards-taxonomy_menu-3003707-2.patch14.97 KB

Now with changes on TaxonomyMenuInterface.php

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Assigned: thalles » Unassigned
andrey.troeglazov’s picture

andrey.troeglazov commented
Assigned: Unassigned » andrey.troeglazov
andrey.troeglazov’s picture

andrey.troeglazov commented
Assigned: andrey.troeglazov » Unassigned
Status: Needs review » Needs work

You should not use any @codingStandardsIgnoreLine use dependency injection instead.

pranali.addweb’s picture

pranali.addweb commented
Assigned: Unassigned » pranali.addweb
Snehal Brahmbhatt’s picture

Snehal Brahmbhatt commented
Status: Needs work » Needs review
StatusFileSize
new taxonomy_menu-3003707-8.patch13.28 KB

Resolved all dependency injection and other coding standard issues. like: @param comment description, Indentation and etc

Status: Needs review » Needs work

The last submitted patch, 9: taxonomy_menu-3003707-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Can we divide this issue into several? One per file?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

This would make it easier to check and apply the patches.
example: https://www.drupal.org/project/taxonomy_menu/issues/3022555

andrey.troeglazov’s picture

andrey.troeglazov commented
Issue tags: -ciandt-contrib, -#ciandt-contrib

No, follow this issue.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new taxonomy_menu-Coding_standards-3003707-14-D8.patch15.31 KB

Follow the patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: taxonomy_menu-Coding_standards-3003707-14-D8.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new taxonomy_menu-Coding_standards-3003707-17-D8.patch15.34 KB

Follow the patch!

Status: Needs review » Needs work

The last submitted patch, 17: taxonomy_menu-Coding_standards-3003707-17-D8.patch, failed testing. View results

karan sen’s picture

karan sen commented
StatusFileSize
new taxonomy_menu-Coding_standards-3003707-19-D8.patch10.33 KB

Please review the patch.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
suparnaa.dey’s picture

suparnaa.dey commented

RTBC

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue summary: View changes
andrey.troeglazov’s picture

andrey.troeglazov commented
Assigned: pranali.addweb » Unassigned
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue tags: +dcnj19
patelmayank7552’s picture

patelmayank7552 commented
Status: Needs review » Needs work

Hi @thalles,

The patch in #19 needs work. Still some coding standard are not fixed.

Thanks and regards.

Mayank Patel

patelmayank7552’s picture

patelmayank7552 commented
Status: Needs work » Needs review
StatusFileSize
new coding_standards-3003707-25.patch13.34 KB

Hi @thalles,

I have fixed the coding standards for this module.

Please review it.

Thanks and regards,
Mayank Patel

Status: Needs review » Needs work

The last submitted patch, 26: coding_standards-3003707-25.patch, failed testing. View results

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Please excuse me, but I'd like to insert some advice.

When commenting about a patch review, please indicate what steps were taken to believe it is ready to change status (moving to rtbc or needs work) . This helps those who are new to the issue queue move forward with a new patch.

Also when changing an improving a patch, it is recommended that an interdiff is added. This makes review easier.
https://www.drupal.org/documentation/git/interdiff

Thanks for helping move the Drupal project forward!!

elaman’s picture

elaman
Primary language English
Location Philadelphia, United States
commented
Status: Needs work » Needs review
StatusFileSize
new 3003707-29.patch15.58 KB
new interdiff-26-29.txt9.33 KB

Coding standards using phpcs.

andrey.troeglazov’s picture

andrey.troeglazov commented
Issue tags: -dcnj19
andrey.troeglazov’s picture

andrey.troeglazov commented
Issue tags: +Taxonomy Menu Release 8.x-3.5

andrey.troeglazov’s picture

andrey.troeglazov commented
Status: Needs review » Fixed
andrey.troeglazov’s picture

andrey.troeglazov commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3158358: Plan for Taxonomy Menu 8.x-3.5
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -Taxonomy Menu Release 8.x-3.5