Closed (works as designed)
Project:
Custom Formatters
Version:
4.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Sep 2018 at 13:03 UTC
Updated:
7 May 2026 at 10:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
chipway commentedHere is the patch. Please review.
I also added the missing last empty line + completed capital letters for names.
Comment #3
chipway commentedComment #4
riddhi.addweb commented@chipway, Thanks for giving the patch, it is working fine as per the standards, I checked the standard errors with Pareview & attached the screenshot for the same.
Comment #5
podarokPatch needs reroll
Comment #6
sandeepsingh199 commentedWith the help of #2 all things are good except custom_formatters_test.info.yml file, Fixing that issue and attaching the patch same. please check and validate.
Comment #7
sandeepsingh199 commentedComment #8
podarokHere is an explanation https://ds-docs.y.org/docs/wiki/dependencies-in-drupal-info.yml/
So it should be
Comment #9
sandeepsingh199 commentedthanks @podarok for your suggestion. Updating the patch same
Comment #10
decipheredThanks for raising this and to everyone who contributed patches over the years.
After looking into it, the current simplified format
- custom_formattersin the test module's info.yml is actually the right approach here.The
project:moduleformat (likedrupal:fieldin the main module) tells Drupal.org packaging to add a composer dependency. That makes sense for cross-project dependencies. But for a test module within the same project, usingcustom_formatters:custom_formatterswould create a redundant self-dependency ondrupal/custom_formatters- the test module is already shipped with the package.The simplified format still enforces the dependency at the module level (Drupal won't let you enable the test module without the main one), it just skips the unnecessary composer part.
Closing as works as designed.