Comments

chipway created an issue. See original summary.

chipway’s picture

Title: Apply new format for dependencies » Apply new format for dependencies + misc coding standard
StatusFileSize
new1.07 KB

Here is the patch. Please review.

I also added the missing last empty line + completed capital letters for names.

chipway’s picture

Assigned: chipway » Unassigned
Status: Needs work » Needs review
riddhi.addweb’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new51.39 KB

@chipway, Thanks for giving the patch, it is working fine as per the standards, I checked the standard errors with Pareview & attached the screenshot for the same.

podarok’s picture

Version: 8.x-3.x-dev » 4.0.x-dev
Status: Reviewed & tested by the community » Needs work
git apply Update_dependencies_format_in_info.yml_3003095-2.patch 
error: patch failed: custom_formatters.info.yml:2
error: custom_formatters.info.yml: patch does not apply
error: patch failed: tests/modules/custom_formatters_test/custom_formatters_test.info.yml:1

Patch needs reroll

sandeepsingh199’s picture

StatusFileSize
new613 bytes

With the help of #2 all things are good except custom_formatters_test.info.yml file, Fixing that issue and attaching the patch same. please check and validate.

sandeepsingh199’s picture

Status: Needs work » Needs review
podarok’s picture

Status: Needs review » Needs work

Here is an explanation https://ds-docs.y.org/docs/wiki/dependencies-in-drupal-info.yml/

So it should be

 - drupal:custom_formatters
sandeepsingh199’s picture

StatusFileSize
new602 bytes

thanks @podarok for your suggestion. Updating the patch same

deciphered’s picture

Status: Needs work » Closed (works as designed)

Thanks for raising this and to everyone who contributed patches over the years.

After looking into it, the current simplified format - custom_formatters in the test module's info.yml is actually the right approach here.

The project:module format (like drupal:field in the main module) tells Drupal.org packaging to add a composer dependency. That makes sense for cross-project dependencies. But for a test module within the same project, using custom_formatters:custom_formatters would create a redundant self-dependency on drupal/custom_formatters - the test module is already shipped with the package.

The simplified format still enforces the dependency at the module level (Drupal won't let you enable the test module without the main one), it just skips the unnecessary composer part.

Closing as works as designed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.