Closed (fixed)
Project:
Contact Emails
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2018 at 15:58 UTC
Updated:
22 Jul 2019 at 14:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
chipway commentedHere is the patch. Please review.
Comment #3
alonaoneill commentedCode looks good. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Thank you for working on module!
Comment #4
johnpicozziI think this issue is preventing the update to 1.17 via composer. I get the following when trying to update via composer.
Comment #5
scott_euser commentedI don't have access to a laptop at the moment but looking at this thread it seems they previously had the same issue:
https://www.drupal.org/project/redirect/issues/2795709
Comment #25 suggests to clear composer caches to solve.
Comment #23 has a simple workaround from your main composer.json just to get the update to happen (after which you can remove as you'll then have the updated info file matching the new standard). Would suggest just trying #25 from there first.
composer clear-cacheLet me know if that solves it.
Comment #6
johnpicozzi@scott_euser - The replace works to get it installed. However, I think it would be better to fix the composer info on d.o so that this isn't needed. Similar to what they say in comment #25 on the Redirect issue.
Comment #7
scott_euser commentedAbsolutely agree if course. Will need to wait until I get access to my laptop again. My work laptop is in repair so using my personal one for that and I do these modules as a volunteer in my free time sorry.
Comment #9
scott_euser commentedThanks!
Comment #10
labboy0276 commentedWhile adding this to composer does bandaid the problem:
The real problem is in the info.yml file. You have the dependency listed as contact:contact, there is no contact contrib module. I checked your dev module from yesterday and it is still there. Sorry to move this from fixed to needs review. Here is a patch to address the problem.
Comment #12
scott_euser commentedThanks!
Comment #13
johnpicozziFWIW - I can confirm this is fixed and composer update is working as it should!