The module on /admin/modules does not link to the settings page yet.

Comments

Baik Ho created an issue. See original summary.

baikho’s picture

StatusFileSize
new237 bytes

See added patch

baikho’s picture

Status: Active » Needs review
liorkesos’s picture

This (and the other patches) are great.
We're actively developing this GitHub.
I'd love if you could open these as separate pull requests with reference to this issue in the title
That was at it's a much faster update and your contribution gets acknowledged publicly .

riddhi.addweb’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new24.7 KB
new62.9 KB
new20.79 KB

@Baik Ho, I Checked your patch, your patch seems perfect for me as per the mentioned requirements, It adds the config link from Extend.

fkelly12054@gmail.com’s picture

Category: Task » Feature request
Priority: Minor » Normal
Status: Reviewed & tested by the community » Needs work

After adding the patch to elementor on Drupal 8.6.4 and uninstalling the module, then trying to reinstall it through extend, I get:

Warning: Invalid argument supplied for foreach() in Elementor\Plugin->add_cpt_support() (line 549 of D:\webpage\drupal8\modules\elementor\elementor\includes\plugin.php). array(19)

→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]

→Notice: Accessing static property Drupal\elementor\ElementorPlugin::$sdk as non static in Drupal\elementor\ElementorPlugin->__construct() (line 451 of D:\webpage\drupal8\modules\elementor\elementor_drupal\ElementorPlugin.php). array(16)

→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]

→Notice: Accessing static property Drupal\elementor\ElementorPlugin::$sdk as non static in Drupal\elementor\ElementorPlugin->register_widget() (line 421 of D:\webpage\drupal8\modules\elementor\elementor_drupal\ElementorPlugin.php). array(17)

→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]

→Notice: Trying to get property of non-object in Elementor\Widgets_Manager->register_wp_widgets() (line 143 of D:\webpage\drupal8\modules\elementor\elementor\includes\managers\widgets.php). array(20)

→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]

→Warning: Invalid argument supplied for foreach() in Elementor\Widgets_Manager->register_wp_widgets() (line 143 of D:\webpage\drupal8\modules\elementor\elementor\includes\managers\widgets.php). array(20)

→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]
The website encountered an unexpected error. Please try again later.
AssertionError: Invalid CSS category: compbasonent. See https://www.drupal.org/node/2274843. in assert() (line 136 of core\lib\Drupal\Core\Asset\LibraryDiscoveryParser.php).

assert(, 'Invalid CSS category: compbasonent. See https://www.drupal.org/node/2274843.') (Line: 136)
Drupal\Core\Asset\LibraryDiscoveryParser->buildByExtension('elementor') (Line: 87)
Drupal\Core\Asset\LibraryDiscoveryCollector->getLibraryDefinitions('elementor') (Line: 66)
Drupal\Core\Asset\LibraryDiscoveryCollector->resolveCacheMiss('elementor') (Line: 149)
Drupal\Core\Cache\CacheCollector->get('elementor') (Line: 44)
Drupal\Core\Asset\LibraryDiscovery->getLibrariesByExtension('elementor') (Line: 58)
Drupal\Core\Asset\LibraryDiscovery->getLibraryByName('elementor', 'global') (Line: 54)
Drupal\Core\Asset\LibraryDependencyResolver->doGetDependencies(Array) (Line: 31)
Drupal\Core\Asset\LibraryDependencyResolver->getLibrariesWithDependencies(Array) (Line: 104)
Drupal\Core\Asset\AssetResolver->getLibrariesToLoad(Object) (Line: 116)
Drupal\Core\Asset\AssetResolver->getCssAssets(Object, ) (Line: 291)
Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAssetLibraries(Object, Array) (Line: 161)
Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAttachments(Object) (Line: 94)
Drupal\big_pipe\Render\BigPipeResponseAttachmentsProcessor->processAttachments(Object) (Line: 45)
Drupal\Core\EventSubscriber\HtmlResponseSubscriber->onRespond(Object, 'kernel.response', Object)
call_user_func(Array, Object, 'kernel.response', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.response', Object) (Line: 191)
Symfony\Component\HttpKernel\HttpKernel->filterResponse(Object, Object, 1) (Line: 173)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 669)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Of course, I was trying it on 8.x-1.6 and not the dev version. But looking at https://www.drupal.org/project/elementor/issues/3000063 which has rtbc status but is not committed, it seems like I am just getting ahead of myself trying to use this. Non-developers such as myself probably need a stable version first.

marabak’s picture

Status: Needs work » Reviewed & tested by the community

The error is not relative to this patch. You should also apply the patch from this issue :
https://www.drupal.org/project/elementor/issues/3001709

gaurav.kapoor’s picture

Pushed, also changed a few other keys in the info.yml file.

  • gaurav.kapoor committed d9616fa on 8.x-1.x
    Issue #3000060 by baikho, riddhi.addweb, gaurav.kapoor: Add configure...
gaurav.kapoor’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.