This (and the other patches) are great.
We're actively developing this GitHub.
I'd love if you could open these as separate pull requests with reference to this issue in the title
That was at it's a much faster update and your contribution gets acknowledged publicly .
After adding the patch to elementor on Drupal 8.6.4 and uninstalling the module, then trying to reinstall it through extend, I get:
Warning: Invalid argument supplied for foreach() in Elementor\Plugin->add_cpt_support() (line 549 of D:\webpage\drupal8\modules\elementor\elementor\includes\plugin.php). array(19)
→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]
→Notice: Accessing static property Drupal\elementor\ElementorPlugin::$sdk as non static in Drupal\elementor\ElementorPlugin->__construct() (line 451 of D:\webpage\drupal8\modules\elementor\elementor_drupal\ElementorPlugin.php). array(16)
→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]
→Notice: Accessing static property Drupal\elementor\ElementorPlugin::$sdk as non static in Drupal\elementor\ElementorPlugin->register_widget() (line 421 of D:\webpage\drupal8\modules\elementor\elementor_drupal\ElementorPlugin.php). array(17)
→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]
→Notice: Trying to get property of non-object in Elementor\Widgets_Manager->register_wp_widgets() (line 143 of D:\webpage\drupal8\modules\elementor\elementor\includes\managers\widgets.php). array(20)
→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]
→Warning: Invalid argument supplied for foreach() in Elementor\Widgets_Manager->register_wp_widgets() (line 143 of D:\webpage\drupal8\modules\elementor\elementor\includes\managers\widgets.php). array(20)
→ Called from <ROOT>/modules/devel/kint/src/Plugin/Devel/Dumper/Kint.php:32 [Drupal\kint\Plugin\Devel\Dumper\Kint->export()]
The website encountered an unexpected error. Please try again later.
AssertionError: Invalid CSS category: compbasonent. See https://www.drupal.org/node/2274843. in assert() (line 136 of core\lib\Drupal\Core\Asset\LibraryDiscoveryParser.php).
assert(, 'Invalid CSS category: compbasonent. See https://www.drupal.org/node/2274843.') (Line: 136)
Drupal\Core\Asset\LibraryDiscoveryParser->buildByExtension('elementor') (Line: 87)
Drupal\Core\Asset\LibraryDiscoveryCollector->getLibraryDefinitions('elementor') (Line: 66)
Drupal\Core\Asset\LibraryDiscoveryCollector->resolveCacheMiss('elementor') (Line: 149)
Drupal\Core\Cache\CacheCollector->get('elementor') (Line: 44)
Drupal\Core\Asset\LibraryDiscovery->getLibrariesByExtension('elementor') (Line: 58)
Drupal\Core\Asset\LibraryDiscovery->getLibraryByName('elementor', 'global') (Line: 54)
Drupal\Core\Asset\LibraryDependencyResolver->doGetDependencies(Array) (Line: 31)
Drupal\Core\Asset\LibraryDependencyResolver->getLibrariesWithDependencies(Array) (Line: 104)
Drupal\Core\Asset\AssetResolver->getLibrariesToLoad(Object) (Line: 116)
Drupal\Core\Asset\AssetResolver->getCssAssets(Object, ) (Line: 291)
Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAssetLibraries(Object, Array) (Line: 161)
Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAttachments(Object) (Line: 94)
Drupal\big_pipe\Render\BigPipeResponseAttachmentsProcessor->processAttachments(Object) (Line: 45)
Drupal\Core\EventSubscriber\HtmlResponseSubscriber->onRespond(Object, 'kernel.response', Object)
call_user_func(Array, Object, 'kernel.response', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.response', Object) (Line: 191)
Symfony\Component\HttpKernel\HttpKernel->filterResponse(Object, Object, 1) (Line: 173)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 669)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Of course, I was trying it on 8.x-1.6 and not the dev version. But looking at https://www.drupal.org/project/elementor/issues/3000063 which has rtbc status but is not committed, it seems like I am just getting ahead of myself trying to use this. Non-developers such as myself probably need a stable version first.
Comments
Comment #2
baikho commentedSee added patch
Comment #3
baikho commentedComment #4
liorkesos commentedThis (and the other patches) are great.
We're actively developing this GitHub.
I'd love if you could open these as separate pull requests with reference to this issue in the title
That was at it's a much faster update and your contribution gets acknowledged publicly .
Comment #5
riddhi.addweb commented@Baik Ho, I Checked your patch, your patch seems perfect for me as per the mentioned requirements, It adds the config link from Extend.
Comment #6
fkelly12054@gmail.com commentedAfter adding the patch to elementor on Drupal 8.6.4 and uninstalling the module, then trying to reinstall it through extend, I get:
Of course, I was trying it on 8.x-1.6 and not the dev version. But looking at https://www.drupal.org/project/elementor/issues/3000063 which has rtbc status but is not committed, it seems like I am just getting ahead of myself trying to use this. Non-developers such as myself probably need a stable version first.
Comment #7
marabak commentedThe error is not relative to this patch. You should also apply the patch from this issue :
https://www.drupal.org/project/elementor/issues/3001709
Comment #8
gaurav.kapoor commentedPushed, also changed a few other keys in the info.yml file.
Comment #10
gaurav.kapoor commented