For the alpha release we need Workbench Moderation support dropped, to match Moderation Sidebar and Note.

Comments

bendeguz.csirmaz created an issue. See original summary.

huzooka’s picture

Status: Active » Needs work
StatusFileSize
new31.31 KB

Attaching my WIP patch.

Note that Moderation dashboard scheduled updates depends on Scheduled Updates module which currently not supports Content moderation: #2821916: Scheduled Updates does not work with Content Moderation

huzooka’s picture

samuel.mortenson’s picture

StatusFileSize
new44.17 KB

Here's a re-roll of #2 - I also removed the moderation_dashboard_scheduled_updates sub-module since we won't be able to get it working (well) without #2821916: Scheduled Updates does not work with Content Moderation being committed. We can add it back later, but shouldn't include it in a release if it depends on a patch.

samuel.mortenson’s picture

Status: Needs work » Needs review
samuel.mortenson’s picture

StatusFileSize
new44.17 KB
new613 bytes

Found a tiny bug - This is ready for review and RTBC now if either of you have time.

samuel.mortenson’s picture

StatusFileSize
new12.83 KB
new56.68 KB

Let's remove the note sub-module as well - Moderation Note has changed since then and now has a superior tab for viewing assigned notes.

huzooka’s picture

+++ b/tests/src/Kernel/ModerationDashboardTest.php
@@ -2,9 +2,8 @@
+use Drupal\Tests\content_moderation\Traits\ContentModerationTestTrait;

I (still) think that this test is a functional test and not a Kernel test, so namespace should be Drupal\Tests\moderation_dashboard\Functional;

Nothing else :)

huzooka’s picture

Assigned: Unassigned » huzooka
Status: Needs review » Needs work
huzooka’s picture

Assigned: huzooka » Unassigned
Status: Needs work » Needs review
StatusFileSize
new626 bytes
new56.88 KB

samuel.mortenson’s picture

Status: Needs review » Fixed

Looks good to me, thanks for all the work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.