Closed (fixed)
Project:
Moderation Dashboard
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Sep 2018 at 09:50 UTC
Updated:
2 Oct 2018 at 17:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
huzookaAttaching my WIP patch.
Note that Moderation dashboard scheduled updates depends on Scheduled Updates module which currently not supports Content moderation: #2821916: Scheduled Updates does not work with Content Moderation
Comment #3
huzookaComment #4
samuel.mortensonHere's a re-roll of #2 - I also removed the
moderation_dashboard_scheduled_updatessub-module since we won't be able to get it working (well) without #2821916: Scheduled Updates does not work with Content Moderation being committed. We can add it back later, but shouldn't include it in a release if it depends on a patch.Comment #5
samuel.mortensonComment #6
samuel.mortensonFound a tiny bug - This is ready for review and RTBC now if either of you have time.
Comment #7
samuel.mortensonLet's remove the note sub-module as well - Moderation Note has changed since then and now has a superior tab for viewing assigned notes.
Comment #8
huzookaI (still) think that this test is a functional test and not a Kernel test, so namespace should be
Drupal\Tests\moderation_dashboard\Functional;Nothing else :)
Comment #9
huzookaComment #10
huzookaComment #12
samuel.mortensonLooks good to me, thanks for all the work!