Given that a user has turned on assistive technology (AT) for e.g. ChromeVox and is interacting with a search component, and the user has submitted a search term which results in autocomplete items. ChromeVox announces the url of the autocomplete search result. For example - if the search result is `Pen` with url `/pen` chromevox announces it as `slash pen` instead of just Pen.

CommentFileSizeAuthor
#7 2999477-7--url_search_result_accessibility.patch3.17 KBdrunken monkey
#7 2999477-7--url_search_result_accessibility--interdiff.txt3.22 KBdrunken monkey
#4 search-api-autocomplete-accessibility-2999477-4.patch623 bytesmikemadison
#2 improve_accessiility_search_results-2999477-2.patch1.22 KBchintan.vyas

Comments

chintan.vyas created an issue. See original summary.

chintan.vyas’s picture

chintan.vyas commented
StatusFileSize
new improve_accessiility_search_results-2999477-2.patch1.22 KB

Attaching the patch for improving accessibility for search results.

Status: Needs review » Needs work

The last submitted patch, 2: improve_accessiility_search_results-2999477-2.patch, failed testing. View results

mikemadison’s picture

mikemadison commented
Status: Needs work » Needs review
StatusFileSize
new search-api-autocomplete-accessibility-2999477-4.patch623 bytes
mikemadison’s picture

mikemadison commented
Version: 8.x-1.0-beta1 » 8.x-1.0
mikemadison’s picture

mikemadison commented
Status: Needs review » Needs work

the suggested template change doesn't resolve the underlying issue here (thanks @chintan.vyas for setting me straight). i think we need to update the associated test to use the solution in #2 to get the suggestions working properly.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 2999477-7--url_search_result_accessibility--interdiff.txt3.22 KB
new 2999477-7--url_search_result_accessibility.patch3.17 KB

Thanks for reporting this problem!

The fail in #2 wasn’t a problem of the test, though, but with the patch: this not only changes the format when a URL is used, but also for normal autocomplete suggestions, resulting in incorrect behavior. The attached patch should fix this.

Also, if we can just set a url key on the autocomplete suggestions, why should we still bother with the leading space? (Didn’t realize this was possible.)
Not 100% sure this doesn’t constitute a BC break, though, changing the format like that. But hopefully this won’t affect too many people. And the format would be a lot cleaner going forward (not relying on the leading space).

Anyways, revised patch attached, please test/review!

chintan.vyas’s picture

chintan.vyas commented

Reviewed and tested #7 on local using Chromevox extension. Search result announcement is working fine.

mikemadison’s picture

mikemadison commented
Status: Needs review » Reviewed & tested by the community

works great for me

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Great to hear, thanks a lot for testing!
Committed.
Thanks again for your work in this issue, both of you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.